From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcG8P-0000r0-Rz for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:14:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcG8O-0001ar-5Y for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:14:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41440 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcG8N-0001aj-R3 for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:14:16 -0400 Message-ID: <4E0C6896.1090105@suse.de> Date: Thu, 30 Jun 2011 14:14:14 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1309260558-3332-1-git-send-email-stefano.stabellini@eu.citrix.com> <4E0C61DF.2050606@suse.de> <4E0C6905.2040604@redhat.com> In-Reply-To: <4E0C6905.2040604@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: xen-devel@lists.xensource.com, mst@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, armbru@redhat.com, anthony.perard@citrix.com On 06/30/2011 02:16 PM, Kevin Wolf wrote: > Am 30.06.2011 13:45, schrieb Alexander Graf: >> On 06/28/2011 01:29 PM, stefano.stabellini@eu.citrix.com wrote: >>> From: Stefano Stabellini >>> >>> The unplug protocol is necessary to support PV drivers in the guest: the >>> drivers expect to be able to "unplug" emulated disks and nics before >>> initializing the Xen PV interfaces. >>> It is responsibility of the guest to make sure that the unplug is done >>> before the emulated devices or the PV interface start to be used. >>> >>> We use pci_for_each_device to walk the PCI bus, identify the devices and >>> disks that we want to disable and dynamically unplug them. >> $ ~/git/qemu/scripts/checkpatch.pl * >> ERROR: space required after that ',' (ctx:VxV) >> #158: FILE: hw/ide/piix.c:240: >> + },{ >> ^ >> >> total: 1 errors, 0 warnings, 130 lines checked > I think checkpatch.pl should be fixed in this case. We do have this > pattern all over the place in qemu and I don't see why it's bad. Hrm. I tend to agree. I'll post a patch :). Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v3] xen: implement unplug protocol in xen_platform Date: Thu, 30 Jun 2011 14:14:14 +0200 Message-ID: <4E0C6896.1090105@suse.de> References: <1309260558-3332-1-git-send-email-stefano.stabellini@eu.citrix.com> <4E0C61DF.2050606@suse.de> <4E0C6905.2040604@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4E0C6905.2040604@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kevin Wolf Cc: xen-devel@lists.xensource.com, mst@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, armbru@redhat.com, anthony@codemonkey.ws, anthony.perard@citrix.com List-Id: xen-devel@lists.xenproject.org On 06/30/2011 02:16 PM, Kevin Wolf wrote: > Am 30.06.2011 13:45, schrieb Alexander Graf: >> On 06/28/2011 01:29 PM, stefano.stabellini@eu.citrix.com wrote: >>> From: Stefano Stabellini >>> >>> The unplug protocol is necessary to support PV drivers in the guest: the >>> drivers expect to be able to "unplug" emulated disks and nics before >>> initializing the Xen PV interfaces. >>> It is responsibility of the guest to make sure that the unplug is done >>> before the emulated devices or the PV interface start to be used. >>> >>> We use pci_for_each_device to walk the PCI bus, identify the devices and >>> disks that we want to disable and dynamically unplug them. >> $ ~/git/qemu/scripts/checkpatch.pl * >> ERROR: space required after that ',' (ctx:VxV) >> #158: FILE: hw/ide/piix.c:240: >> + },{ >> ^ >> >> total: 1 errors, 0 warnings, 130 lines checked > I think checkpatch.pl should be fixed in this case. We do have this > pattern all over the place in qemu and I don't see why it's bad. Hrm. I tend to agree. I'll post a patch :). Alex