From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Fri, 01 Jul 2011 17:17:16 +0200 Subject: [U-Boot] [PATCH 6/8] Adds wait to atmel_usart serial_init function In-Reply-To: <4E0DBF77.3030602@dawning.com> References: <4E0C6CDC.4020806@dawning.com> <1309462387-22926-1-git-send-email-awaterman@dawning.com> <1309462387-22926-7-git-send-email-awaterman@dawning.com> <4E0DB79E.60301@mvista.com> <4E0DBF77.3030602@dawning.com> Message-ID: <4E0DE4FC.2030601@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alex, Le 01/07/2011 14:37, Alex Waterman a ?crit : > >> Why 'volatile'? Also, there shouldn't be an empty line before it but there should be one after it... > I used a volatile to prevent the compiler from optimizing out the (normally) useless loop. Is there a cleaner way to do this? If the board supports udelay(), you should use that instead of a loop. > Best regards, > Alex Amicalement, -- Albert.