From: Felix Fietkau <nbd@openwrt.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH v2 1/8] ath5k: add missing checks for rfgain probe
Date: Tue, 05 Jul 2011 11:48:08 +0700 [thread overview]
Message-ID: <4E129788.4040803@openwrt.org> (raw)
In-Reply-To: <CAFtRNNwK_LjP_2cAp0macP+8My4nzextWMNz9pLTKRW6V8tDjw@mail.gmail.com>
On 2011-07-05 11:46 AM, Nick Kossifidis wrote:
> 2011/7/5 Felix Fietkau<nbd@openwrt.org>:
>> rfgain probe is only necessary for OFDM operation on AR5111 and AR5112.
>>
>> Signed-off-by: Felix Fietkau<nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath5k/phy.c | 10 ++++++----
>> 1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
>> index 5544191..d0bfcad 100644
>> --- a/drivers/net/wireless/ath/ath5k/phy.c
>> +++ b/drivers/net/wireless/ath/ath5k/phy.c
>> @@ -1604,11 +1604,13 @@ int ath5k_hw_phy_calibrate(struct ath5k_hw *ah,
>> int ret;
>>
>> if (ah->ah_radio == AR5K_RF5110)
>> - ret = ath5k_hw_rf5110_calibrate(ah, channel);
>> - else {
>> - ret = ath5k_hw_rf511x_iq_calibrate(ah);
>> + return ath5k_hw_rf5110_calibrate(ah, channel);
>> +
>> + ret = ath5k_hw_rf511x_iq_calibrate(ah);
>> +
>> + if ((ah->ah_radio == AR5K_RF5112 || ah->ah_radio == AR5K_RF5112)&&
>
> You probably mean
> ah->ah_radio == AR5K_RF5111 || ah->ah_radio == AR5K_RF5112
You're right. I need to be more careful with copy&paste ;)
Will send a v3 once you've looked over the other patches.
- Felix
next prev parent reply other threads:[~2011-07-05 4:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 3:11 [PATCH v2 1/8] ath5k: add missing checks for rfgain probe Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 4/8] ath5k: initialize common->clockrate Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 5/8] ath5k: delay full calibration after reset Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 7/8] ath5k: disable 32KHz sleep clock operation by default Felix Fietkau
2011-07-05 3:11 ` [PATCH v2 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 Felix Fietkau
2011-07-11 21:26 ` [PATCH v2 7/8] ath5k: disable 32KHz sleep clock operation by default Nick Kossifidis
2011-07-05 4:46 ` [PATCH v2 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis
2011-07-05 4:48 ` Felix Fietkau [this message]
2011-07-11 18:37 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E129788.4040803@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.