From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/5] scsi-disk: Fixup debugging statement Date: Tue, 05 Jul 2011 13:05:32 +0200 Message-ID: <4E12EFFC.3020105@redhat.com> References: <1309863815-28236-1-git-send-email-hare@suse.de> <1309863815-28236-2-git-send-email-hare@suse.de> <1309863815-28236-3-git-send-email-hare@suse.de> <1309863815-28236-4-git-send-email-hare@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Stefan Haynoczi , kvm@vger.kernel.org, Alexander Graf To: Hannes Reinecke Return-path: Received: from mx1.redhat.com ([209.132.183.28]:28121 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755740Ab1GELFp (ORCPT ); Tue, 5 Jul 2011 07:05:45 -0400 In-Reply-To: <1309863815-28236-4-git-send-email-hare@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 07/05/2011 01:03 PM, Hannes Reinecke wrote: > A debugging statement wasn't converted to the new interface. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-disk.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index c2a99fe..5804662 100644 > --- a/hw/scsi-disk.c > +++ b/hw/scsi-disk.c > @@ -1007,7 +1007,7 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *buf) > > command = buf[0]; > outbuf = (uint8_t *)r->iov.iov_base; > - DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", lun, tag, buf[0]); > + DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", req->lun, req->tag, buf[0]); > > if (scsi_req_parse(&r->req, buf) != 0) { > BADF("Unsupported command length, command %x\n", command); Acked-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qe3Rq-00006O-4Q for qemu-devel@nongnu.org; Tue, 05 Jul 2011 07:05:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qe3Rn-0005vc-9G for qemu-devel@nongnu.org; Tue, 05 Jul 2011 07:05:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qe3Rm-0005vD-Sy for qemu-devel@nongnu.org; Tue, 05 Jul 2011 07:05:43 -0400 Message-ID: <4E12EFFC.3020105@redhat.com> Date: Tue, 05 Jul 2011 13:05:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1309863815-28236-1-git-send-email-hare@suse.de> <1309863815-28236-2-git-send-email-hare@suse.de> <1309863815-28236-3-git-send-email-hare@suse.de> <1309863815-28236-4-git-send-email-hare@suse.de> In-Reply-To: <1309863815-28236-4-git-send-email-hare@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/5] scsi-disk: Fixup debugging statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: Alexander Graf , qemu-devel@nongnu.org, kvm@vger.kernel.org, Stefan Haynoczi On 07/05/2011 01:03 PM, Hannes Reinecke wrote: > A debugging statement wasn't converted to the new interface. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-disk.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index c2a99fe..5804662 100644 > --- a/hw/scsi-disk.c > +++ b/hw/scsi-disk.c > @@ -1007,7 +1007,7 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *buf) > > command = buf[0]; > outbuf = (uint8_t *)r->iov.iov_base; > - DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", lun, tag, buf[0]); > + DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", req->lun, req->tag, buf[0]); > > if (scsi_req_parse(&r->req, buf) != 0) { > BADF("Unsupported command length, command %x\n", command); Acked-by: Paolo Bonzini