From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aneesh V <aneesh@ti.com>
Date: Fri, 08 Jul 2011 15:50:10 +0530
Subject: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in
	spl/Makefile
In-Reply-To: <20110708090838.E92A9126F38F@gemini.denx.de>
References: <1309352967-5719-1-git-send-email-aneesh@ti.com>
	<1309883182-12854-1-git-send-email-daniel.schwierzeck@googlemail.com>
	<1309883182-12854-2-git-send-email-daniel.schwierzeck@googlemail.com>
	<20110708090838.E92A9126F38F@gemini.denx.de>
Message-ID: <4E16D9DA.4080803@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

On Friday 08 July 2011 02:38 PM, Wolfgang Denk wrote:
> Dear Daniel Schwierzeck,
>
> In message<1309883182-12854-2-git-send-email-daniel.schwierzeck@googlemail.com>  you wrote:
>> [aneesh at ti.com:
>> 1. Changed the definition of OBJTREE and the way 'obj' is defined.
>> 2. Defined a flag to identify regular U-Boot build
>> 3. Taking care of autoconf.mk etc for SPL due to changed OBJTREE
>> ]
>>
>> [daniel.schwierzeck at googlemail.com:
>> 1. reverted changes on implicite make rules
>> 2. readded definition of -DCONFIG_UBOOT_SPL_BUILD in CPPFLAGS
>> ]
> ...
>> +# Allow compiling of C and ASM code parts in different way.
>> +# Serves also as a replacement for CONFIG_PRELOADER.
>> +ifneq ($(CONFIG_UBOOT_SPL_BUILD),)
>> +CPPFLAGS += -DCONFIG_UBOOT_SPL_BUILD
>> +endif
>
> I don't understand this comment.
>
>> +CONFIG_NORMAL_UBOOT = $(if $(CONFIG_UBOOT_SPL_BUILD),,y)
>
> Is this not redundant, then?

Yes, it is. But it was handy for conditional inclusion of source files
in the Makefiles, like this:

+# used only by normal u-boot
+COBJS-$(CONFIG_NORMAL_UBOOT)	+= fileA.o
+# used only by SPL
+COBJS-$(CONFIG_UBOOT_SPL_BUILD)	+= fileB.o
+# used by SPL and normal u-boot
+COBJS-y	+= fileC.o

Without CONFIG_NORMAL_UBOOT this becomes a little cumbersome.

best regards,
Aneesh