All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: Error routes through omap3isp ccdc.
Date: Mon, 11 Jul 2011 12:16:32 +0100	[thread overview]
Message-ID: <4E1ADB90.8050305@cam.ac.uk> (raw)
In-Reply-To: <201107111257.24089.laurent.pinchart@ideasonboard.com>

On 07/11/11 11:57, Laurent Pinchart wrote:
> On Monday 11 July 2011 12:54:42 Laurent Pinchart wrote:
>> On Monday 11 July 2011 12:41:49 Jonathan Cameron wrote:
> 
> [snip]
> 
>> I think we should try to fix it in ispvideo.c instead. You could add a
>> check to isp_video_validate_pipeline() to make sure that the pipeline has
>> a video source.
> 
> And I forgot to mention, I can send a patch if you don't want to write it.
> 
Given I can't quite see why the validate_pipeline code would ever want to break
on source pad being null (which I think is what it is currently doing),
I'll leave it to you.  Really don't know this code well enough!

Thanks.

Jonathan

  reply	other threads:[~2011-07-11 11:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 10:41 Error routes through omap3isp ccdc Jonathan Cameron
2011-07-11 10:54 ` Laurent Pinchart
2011-07-11 10:57   ` Laurent Pinchart
2011-07-11 11:16     ` Jonathan Cameron [this message]
2011-07-31 15:15       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1ADB90.8050305@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.