From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgN7o-0002Lm-UR for qemu-devel@nongnu.org; Mon, 11 Jul 2011 16:30:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgN7n-0005ga-3R for qemu-devel@nongnu.org; Mon, 11 Jul 2011 16:30:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgN7m-0005gH-EM for qemu-devel@nongnu.org; Mon, 11 Jul 2011 16:30:38 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6BKUbaE002500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Jul 2011 16:30:37 -0400 Message-ID: <4E1B5D09.6050403@redhat.com> Date: Mon, 11 Jul 2011 22:28:57 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1310407269-13203-1-git-send-email-Jes.Sorensen@redhat.com> <20110711172456.5f61adbb@doriath> In-Reply-To: <20110711172456.5f61adbb@doriath> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 07/11/11 22:24, Luiz Capitulino wrote: > On Mon, 11 Jul 2011 20:01:09 +0200 > Jes.Sorensen@redhat.com wrote: > >> > From: Jes Sorensen >> > >> > Add QMP bits for snapshot_blkdev command. This is the same as >> > snapshot_blkdev in the human monitor. The command is synchronous. >> > >> > In the future async commands and or a break down of the functionality >> > into multiple commands might be added. >> > >> > Signed-off-by: Jes Sorensen >> > --- >> > qmp-commands.hx | 35 +++++++++++++++++++++++++++++++++++ >> > 1 files changed, 35 insertions(+), 0 deletions(-) >> > >> > diff --git a/qmp-commands.hx b/qmp-commands.hx >> > index 92c5c3a..2b9f6af 100644 >> > --- a/qmp-commands.hx >> > +++ b/qmp-commands.hx >> > @@ -694,6 +694,41 @@ Example: >> > EQMP >> > >> > { >> > + .name = "blockdev-snapshot-sync", >> > + .args_type = "device:B,snapshot-file:s?,format:s?", > You changed from an underline to a hyphen as I asked, but the implementation > still expects an underline. I fixed that myself to avoid multiple submissions > because of a small thing (also fixed the command name in the subject). > > The patch I merged follows for reference. Please, test your patches before > submitting next time. > > Sorry that is no go, you just broke the hmp implementation - you cannot change the hmp behavior like that. Jes