From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: viro@zeniv.linux.org.uk, jeffm@suse.com, chris.mason@oracle.com,
jack@suse.cz, reiserfs-devel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] ext3: make ext3 mount default to barrier=1
Date: Mon, 11 Jul 2011 19:16:06 -0500 [thread overview]
Message-ID: <4E1B9246.3060507@redhat.com> (raw)
In-Reply-To: <20110711182558.GB12099@infradead.org>
On 7/11/11 1:25 PM, Christoph Hellwig wrote:
> From: Chris Mason <mason@suse.com>
>
> This patch turns on barriers by default for ext3. mount -o barrier=0
> will turn them off.
>
> Acked-by: Jeff Mahoney <jeffm@suse.com>
>
> Index: linux-2.6/fs/ext3/super.c
> ===================================================================
> --- linux-2.6.orig/fs/ext3/super.c 2011-06-30 21:19:37.389544975 +0200
> +++ linux-2.6/fs/ext3/super.c 2011-07-02 13:56:51.877784292 +0200
> @@ -1718,6 +1718,8 @@ static int ext3_fill_super (struct super
> sbi->s_resuid = le16_to_cpu(es->s_def_resuid);
> sbi->s_resgid = le16_to_cpu(es->s_def_resgid);
>
> + /* enable barriers by default */
> + set_opt(sbi->s_mount_opt, BARRIER);
> set_opt(sbi->s_mount_opt, RESERVATION);
>
> if (!parse_options ((char *) data, sb, &journal_inum, &journal_devnum,
Thank you, I hope it will get upstream THIS time ;)
As Jan said, despite uptream rejection last time, RHEL6 and SuSE have made this change anyway, because it's the Right Thing To Do.
Acked-by: Eric Sandeen <sandeen@redhat.com>
-Eric
next prev parent reply other threads:[~2011-07-12 0:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 18:25 [PATCH 0/2] always default to issue cache flushes Christoph Hellwig
2011-07-11 18:25 ` [PATCH 1/2] ext3: make ext3 mount default to barrier=1 Christoph Hellwig
2011-07-11 19:17 ` Jan Kara
2011-07-11 19:20 ` Christoph Hellwig
2011-07-11 22:23 ` Ted Ts'o
2011-07-12 0:16 ` Eric Sandeen [this message]
2011-07-12 13:24 ` Chris Mason
2011-07-14 15:19 ` Christoph Hellwig
2011-07-11 18:26 ` [PATCH 2/2] reiserfs: make reiserfs default to barrier=flush Christoph Hellwig
2011-07-11 19:19 ` [PATCH 0/2] always default to issue cache flushes Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1B9246.3060507@redhat.com \
--to=sandeen@redhat.com \
--cc=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.