From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Qh0AO-0005FQ-Bt
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 10:11:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Qh0AN-0001a3-2h
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 10:11:56 -0400
Received: from mail-ww0-f41.google.com ([74.125.82.41]:35345)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Qh0AM-0001Zo-La
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 10:11:54 -0400
Received: by wwi14 with SMTP id 14so521553wwi.4
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2011 07:11:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E1DA7A6.6060104@redhat.com>
Date: Wed, 13 Jul 2011 16:11:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1310562411-30538-1-git-send-email-minovotn@redhat.com>
In-Reply-To: <1310562411-30538-1-git-send-email-minovotn@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor
	command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Novotny <minovotn@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/13/2011 03:06 PM, Michal Novotny wrote:
> +uint64_t time_get(const char *name, int stage);
> +void time_set(const char *name, int stage, uint64_t tv);
> +void time_add(const char *name, int stage, uint64_t tv);
> +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2);
> +uint64_t save_total_time(void);

Please inline all these instead of adding new functions.

> +
>   /* SLIRP */
>   void do_info_slirp(Monitor *mon);
>
> diff --git a/vl.c b/vl.c
> index fcd7395..340cbe3 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -229,6 +229,12 @@ unsigned int nb_prom_envs = 0;
>   const char *prom_envs[MAX_PROM_ENVS];
>   int boot_menu;
>
> +/* Times */
> +static uint64_t time_save_total[3];
> +static uint64_t time_save_disk[3];
> +static uint64_t time_save_ram[3];
> +static uint64_t time_save_wait_input;

Please move these to savevm.c instead.  The implementation of the 
monitor command can also go to savevm.c.

Thanks,

Paolo