From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55592)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhHTO-00045G-Cp
	for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:40:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhHTM-0001ph-Et
	for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:40:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhHTL-0001pc-Tl
	for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:40:40 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6E8edwi013466
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 14 Jul 2011 04:40:39 -0400
Message-ID: <4E1EAB84.1070305@redhat.com>
Date: Thu, 14 Jul 2011 10:40:36 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310568597-24181-1-git-send-email-alevy@redhat.com>
	<1310568597-24181-6-git-send-email-alevy@redhat.com>
In-Reply-To: <1310568597-24181-6-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv4 05/11] qxl: add io_port_to_string
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

   Hi,

> +    case QXL_IO_UPDATE_AREA_ASYNC:
> +        return "QXL_IO_UPDATE_AREA_ASYNC";

Fails to build with old libspice-server (well, old libspice-protocol to 
be exact).  Needs #ifdef.  Using SPICE_INTERFACE_QXL_MINOR should work 
fine as the new libspice-server depends on the new spice-protocol too.

cheers,
   Gerd