From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Sun, 17 Jul 2011 10:26:12 +0200 Subject: [U-Boot] [PATCH V3 3/4] ARM: Warn when the machine ID isn't set. In-Reply-To: <4E2286CC.5010000@compulab.co.il> References: <20110707143424.GD5438@harvey-pc.matrox.com> <20110714180240.GA21529@harvey-pc.matrox.com> <4E1F3D39.3050207@compulab.co.il> <4E20363B.1020408@denx.de> <4E2286CC.5010000@compulab.co.il> Message-ID: <4E229CA4.3020902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 17/07/2011 08:53, schrieb Igor Grinberg: >>> Also, in the printf line, you are mixing tabs with spaces >>> (sorry for not noticing this in previous versions...). >> ...and if you want to print something only for debug purposes, the best >> way is to substitute printf() with debug() and get rid of #ifdef. >> >> + if (machid == BI_ARCH_NUMBER_INVALID) >> + debug("Warning: machid not set.\n"); > > That is understood completely and that is not what I'm asking... > I think that this warning should be printed not just for debug purposes... > So, I'd prefer: > > + if (machid == BI_ARCH_NUMBER_INVALID) > + printf("Warning: machid not set.\n"); > > with no #ifdefs. Agree. And because the goal of thi patch is to warn when the mach-id is not set, I am expecting to see this warning on the console without recompiling the code. > So, I'm asking is it essential to make it only for debug purposes? IMHO, I think no. > Are there any cases when this code will harm if no #define DEBUG is specified? Agree with you, I do not see any reason to output the warning only if DEBUG is set Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================