All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: "Hadli, Manjunath" <manjunath.hadli@ti.com>
Cc: LMML <linux-media@vger.kernel.org>,
	dlos <davinci-linux-open-source@linux.davincidsp.com>,
	"Netagunte, Nagabhushana" <nagabhushana.netagunte@ti.com>
Subject: Re: [RFC PATCH 1/8] davinci: vpfe: add dm3xx IPIPEIF hardware support module
Date: Tue, 19 Jul 2011 22:23:36 +0300	[thread overview]
Message-ID: <4E25D9B8.9070109@iki.fi> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024BCEF740@dbde02.ent.ti.com>

Hadli, Manjunath wrote:
> Sakari, Thank you for your comments. I agree with them and fix.
> Please comment
on the rest of the patches as well.
> -Manju>

Hi Manju,

I'll attempt to find more time for this.

[clip]

>>> +/* CFG1 Masks and shifts */
>>> +#define ONESHOT_SHIFT                      (0)
>>> +#define DECIM_SHIFT                        (1)
>>> +#define INPSRC_SHIFT                       (2)
>>> +#define CLKDIV_SHIFT                       (4)
>>> +#define AVGFILT_SHIFT                      (7)
>>> +#define PACK8IN_SHIFT                      (8)
>>> +#define IALAW_SHIFT                        (9)
>>> +#define CLKSEL_SHIFT                       (10)
>>> +#define DATASFT_SHIFT                      (11)
>>> +#define INPSRC1_SHIFT                      (14)
>>
>> IPIPEIF prefix. Are these related to a particular register or a set of registers?
> One register. Will need to add the IPIPEIF prefix.

Assuming CFG1 is the name of the register, what about IPIPEIF_CFG1_...?

>>> +/* DPC2 */
>>> +#define IPIPEIF_DPC2_EN_SHIFT              (12)
>>> +#define IPIPEIF_DPC2_THR_MASK              (0xFFF)
>>> +#define IPIPEIF_DF_GAIN_EN_SHIFT   (10)
>>> +#define IPIPEIF_DF_GAIN_MASK               (0x3FF)
>>> +#define IPIPEIF_DF_GAIN_THR_MASK   (0xFFF)

Also all of these should have DPC2 prefix before DPC2 if they're all for
the same register.

Regards,

-- 
Sakari Ailus
sakari.ailus@iki.fi

  reply	other threads:[~2011-07-19 19:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 13:13 [ RFC PATCH 0/8] RFC for Media Controller capture driver for DM365 Manjunath Hadli
2011-06-30 13:13 ` [RFC PATCH 1/8] davinci: vpfe: add dm3xx IPIPEIF hardware support module Manjunath Hadli
2011-07-13 18:50   ` Sakari Ailus
2011-07-19 10:51     ` Hadli, Manjunath
2011-07-19 19:23       ` Sakari Ailus [this message]
2011-08-29 15:19     ` Hadli, Manjunath
2011-08-31 11:23       ` 'Sakari Ailus'
2011-10-23 18:30         ` new mbus formats Hadli, Manjunath
2011-11-02 14:20           ` Laurent Pinchart
2011-06-30 13:13 ` [RFC PATCH 2/8] davinci: vpfe: add IPIPE hardware layer support Manjunath Hadli
2011-08-07 23:03   ` Sakari Ailus
2011-08-08 16:25     ` Hadli, Manjunath
2011-06-30 13:13 ` [RFC PATCH 3/8] davinci: vpfe: add IPIPE support for media controller driver Manjunath Hadli
2011-06-30 13:13 ` [RFC PATCH 4/8] davinci: vpfe: add support for CCDC hardware for dm365 Manjunath Hadli
2011-06-30 13:13 ` [RFC PATCH 5/8] davinci: vpfe: add ccdc driver with media controller interface Manjunath Hadli
2011-06-30 13:13 ` [RFC PATCH 6/8] davinci: vpfe: add v4l2 video driver support Manjunath Hadli
2011-06-30 13:13 ` [RFC PATCH 7/8] davinci: vpfe: v4l2 capture driver with media interface Manjunath Hadli
2011-06-30 13:13 ` [RFC PATCH 8/8] davinci: vpfe: build infrastructure for dm365 Manjunath Hadli
2011-06-30 13:57 ` [ RFC PATCH 0/8] RFC for Media Controller capture driver for DM365 Sakari Ailus
2011-07-04  5:58   ` Hadli, Manjunath
2011-07-04 13:22     ` Laurent Pinchart
2011-07-04 14:55       ` Hadli, Manjunath
2011-07-04 16:13         ` Sakari Ailus
2011-07-06  5:40           ` Hadli, Manjunath
2011-07-12 12:01             ` Hadli, Manjunath
2011-07-12 21:22               ` 'Sakari Ailus'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E25D9B8.9070109@iki.fi \
    --to=sakari.ailus@iki.fi \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=manjunath.hadli@ti.com \
    --cc=nagabhushana.netagunte@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.