All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Dietsche <gregory.dietsche@cuw.edu>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] x86: smpboot: mark array as const
Date: Wed, 20 Jul 2011 02:03:34 +0000	[thread overview]
Message-ID: <4E263776.6080402@cuw.edu> (raw)
In-Reply-To: <1309482653-23648-1-git-send-email-Gregory.Dietsche@cuw.edu>



On 06/30/2011 08:10 PM, Greg Dietsche wrote:
> This array is read-only. Make it explicit by marking as const.
>
> Signed-off-by: Greg Dietsche<Gregory.Dietsche@cuw.edu>
> ---
>   arch/x86/kernel/smpboot.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 9fd3137..9f548cb 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -438,7 +438,7 @@ static void impress_friends(void)
>   void __inquire_remote_apic(int apicid)
>   {
>   	unsigned i, regs[] = { APIC_ID>>  4, APIC_LVR>>  4, APIC_SPIV>>  4 };
> -	char *names[] = { "ID", "VERSION", "SPIV" };
> +	const char * const names[] = { "ID", "VERSION", "SPIV" };
>   	int timeout;
>   	u32 status;
>
>    
adding trivial@kernel.org to the cc list since this is trivial and no 
one has picked up this patch to date.

Greg


  reply	other threads:[~2011-07-20  2:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  1:10 Greg Dietsche
2011-07-20  2:03 ` Greg Dietsche [this message]
2011-07-21 10:10 ` [tip:x86/cleanups] x86, smpboot: Mark the names[] array in __inquire_remote_apic() " tip-bot for Greg Dietsche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E263776.6080402@cuw.edu \
    --to=gregory.dietsche@cuw.edu \
    --cc=kernel-janitors@vger.kernel.org \
    --subject='Re: [PATCH v2] x86: smpboot: mark array as const' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.