From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjVvV-0000bQ-Fw for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:30:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjVvT-00079j-Ob for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:30:57 -0400 Received: from afflict.kos.to ([92.243.29.197]:36264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjVvT-00079K-7Z for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:30:55 -0400 Message-ID: <4E26CA75.7020506@iki.fi> Date: Wed, 20 Jul 2011 15:30:45 +0300 From: riku voipio MIME-Version: 1.0 References: <1309857568-2861-1-git-send-email-khansa@kics.edu.pk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] MIPS64 user mode emulation in QEMU with Cavium specific instruction support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Khansa Butt Cc: Nathan Froyd , qemu-devel@nongnu.org, Aurelien Jarno Hi, On 07/12/2011 02:09 PM, Khansa Butt wrote: > We have developed Mips64 user mode emulation. In addition we implemented > Cavium specific instruction along with octeon CPU definition. We need your > support to make our contribution public ally available via making it open > source. I tried to resolve the issues pointed out by Aurelien Jarno, Riku, > Nathan and other friends and send the patches on Jul 5. Please review > the patch series and give your feedback in the form of comments and > suggestions I can only comment on the 1/3 part which touches linux-user code. I would prefer not change linux-user/signal.c just for changing code comment, but the rest of patch seems ok. However, the patch depends on changes in 2/3, so I can't apply it without the rest patches already included upstream by the target-mips maintainer. Riku