All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH_v2 4/4] test: add script to set credentials for cdma connection
Date: Thu, 21 Jul 2011 04:56:34 -0500	[thread overview]
Message-ID: <4E27F7D2.7060802@gmail.com> (raw)
In-Reply-To: <1311223244-26904-5-git-send-email-guillaume.zajac@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Hi Guillaume,

On 07/20/2011 11:40 PM, Guillaume Zajac wrote:
> ---
>  test/create-cdma-credentials |   29 +++++++++++++++++++++++++++++
>  1 files changed, 29 insertions(+), 0 deletions(-)
>  create mode 100755 test/create-cdma-credentials

Can you rename this script to cdma-set-credentials?  I want to follow
our current convention and prefix all cdma related test scripts with cdma.

Also, you are forgetting Makefile.am changes here, the script should be
added to the relevant section in Makefile.am.

Regards,
-Denis

      reply	other threads:[~2011-07-21  9:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21  4:40 [PATCH_v2 0/4] CDMA-connman add username and password properties Guillaume Zajac
2011-07-21  4:40 ` [PATCH_v2 1/4] cdma-connman: pass username and password to drivers while activating cdma-connman Guillaume Zajac
2011-07-21  9:52   ` Denis Kenzior
2011-07-21  4:40 ` [PATCH_v2 2/4] cdma-connman: add username and password, pass them to drivers Guillaume Zajac
2011-07-21  9:54   ` Denis Kenzior
2011-07-21  4:40 ` [PATCH_v2 3/4] driver cdma-connman: pass credentials into activate function Guillaume Zajac
2011-07-21  9:54   ` Denis Kenzior
2011-07-21  4:40 ` [PATCH_v2 4/4] test: add script to set credentials for cdma connection Guillaume Zajac
2011-07-21  9:56   ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E27F7D2.7060802@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.