From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v5 00/86] Memory API Date: Thu, 21 Jul 2011 17:40:50 +0300 Message-ID: <4E283A72.2080908@redhat.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> <4E27132E.6080504@siemens.com> <4E2713C9.1030604@redhat.com> <4E274C06.40902@web.de> <4E27E52D.1090600@redhat.com> <4E282BDD.9010206@siemens.com> <4E282D19.1040506@redhat.com> <4E283561.9040801@siemens.com> <4E283858.8020203@redhat.com> <4E28390A.8090503@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59387 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742Ab1GUOk6 (ORCPT ); Thu, 21 Jul 2011 10:40:58 -0400 In-Reply-To: <4E28390A.8090503@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/21/2011 05:34 PM, Jan Kiszka wrote: > On 2011-07-21 16:31, Avi Kivity wrote: > > On 07/21/2011 05:19 PM, Jan Kiszka wrote: > >>>> Makes some sense. I even wonder if this isn't a KVM deficit and should > >>>> be handled there when a logged region is unmapped. > >>> > >>> What do you mean? There is a known issue with kvm here, this is a just > >>> workaround. > >> > >> Then the logic indeed belongs to kvm-all.c, not memory.c. > >> > > > > Does kvm-all.c have all the information? > > If should as it keeps a record of the active slots with the logging > flag. So, if a slot with logging on is changed, the dirty bits should be > set. > Ok. We'd need to teach it about the memory API as well - there is no longer a global ram_addr_t that can be used. But that's not too hard. > > > > btw, where do you see the issue? which guest? > > > > Somehow you see a lot more problems than I do. > > Stock OpenSUSE 11.4 with grub2 in graphical mode, -vga cirrus. Ah, I use regular grub. Will try g2. -- error compiling committee.c: too many arguments to function