From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkGsB-0002eX-0t for qemu-devel@nongnu.org; Fri, 22 Jul 2011 10:38:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkGsA-0007zV-3l for qemu-devel@nongnu.org; Fri, 22 Jul 2011 10:38:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkGs9-0007zN-PP for qemu-devel@nongnu.org; Fri, 22 Jul 2011 10:38:37 -0400 Message-ID: <4E298C16.9080504@redhat.com> Date: Fri, 22 Jul 2011 16:41:26 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-9-git-send-email-armbru@redhat.com> In-Reply-To: <1311179069-27882-9-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/55] block: Make BlockDriver method bdrv_eject() return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: quintela@redhat.com, dbaryshkov@gmail.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com Am 20.07.2011 18:23, schrieb Markus Armbruster: > Callees always return 0, except for FreeBSD's cdrom_eject(), which > returns -ENOTSUP when the device is in a terminally wedged state. > > The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since > commit 4be9762a. > > Signed-off-by: Markus Armbruster What about failed ioctls? Currently we only print an error message but still return 0. Is this the right behaviour? Could callers make use of an error return here or would we end up like with bdrv_set_locked() where we can't really communicate the error to the guest? Kevin