From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qkygi-0001SY-Kq for qemu-devel@nongnu.org; Sun, 24 Jul 2011 09:25:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qkygh-0001AR-F6 for qemu-devel@nongnu.org; Sun, 24 Jul 2011 09:25:44 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:61690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qkygh-0001AN-Ca for qemu-devel@nongnu.org; Sun, 24 Jul 2011 09:25:43 -0400 Received: by yia25 with SMTP id 25so2233412yia.4 for ; Sun, 24 Jul 2011 06:25:42 -0700 (PDT) Message-ID: <4E2C1D54.8020908@codemonkey.ws> Date: Sun, 24 Jul 2011 08:25:40 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1310633908-11520-1-git-send-email-cyliu@novell.com> <4E2AE76A.1050302@codemonkey.ws> <7740093E-1D7B-4D0C-8D77-5C9126BCB52D@suse.de> <4E2B1CEB.5040606@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] Add "tee" option to qemu char device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Chunyan Liu , qemu-devel@nongnu.org On 07/24/2011 04:47 AM, Alexander Graf wrote: > >> These arguments all apply to any possible option. Why not a grep target? Why not a cut or less target? > > Because they don't make sense. Neither does tee :-) >>> As long as the tee target is reasonably isolated, I don't think it'd clutter the char backend. >> >> It'll never be tested and end up becoming dead bloat code. > > I'll be extensively tested in Xen code, since that's how Xen will invoke qemu. If this is being used by Xen as part of Xend, then there's really no point in worrying about complexity because the user will never be exposed to it. > > I tend to agree, but this time the solution in qemu is cleaner and easier IMHO. Let's compare the typical use-case: qemu -hda linux.img -nographic | tee boot.log vs: qemu -hda linux.img -serial tee:boot.log,stdio I'm not even sure I got the syntax right on the later. > Also, I've had issues with tee several times already. Then we should fix those issues. But I have a hard time believing there were ever issues. This is just piping. > I'm in favor of putting a tee target into qemu's char layer and I'm sure it'll become a well used target. It will only be used by Xen and Xen could very easily solve this problem outside of qemu. It adds another twisted command line syntax that will make it harder to generalize later. Regards, Anthony Liguori > > Alex > >