From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes Date: Mon, 25 Jul 2011 16:28:12 +0300 Message-ID: <4E2D6F6C.5070301@redhat.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> <4E2D6A97.9050606@codemonkey.ws> <4E2D6C45.5030308@redhat.com> <20110725131728.GD4404@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1255; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12611 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178Ab1GYN2S (ORCPT ); Mon, 25 Jul 2011 09:28:18 -0400 In-Reply-To: <20110725131728.GD4404@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2011 04:17 PM, Gleb Natapov wrote: > On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: > > On 07/25/2011 04:07 PM, Anthony Liguori wrote: > > >On 07/20/2011 11:50 AM, Avi Kivity wrote: > > >>The current implementation of PAM and the PCI holes is broken in= several > > >>ways: > > >> > > >> - PCI BARs are not restricted to the PCI hole (a BAR may hid= e memory) > > > > > >Technically, a BAR can be mapped to any non-RAM memory location. > > > > I understood TOM (Top Of Memory) to be fixed - can't find a regist= er > > for it - but maybe I misread the spec. > > > PIIX3 spec: > > 2.2.11. TOM=97TOP OF MEMORY REGISTER (Function 0) > Address Offset: 69h > Default Value: 02h > Attribute: Read/Write > What's it doing in PIIX3? Is it the same TOM? --=20 error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlLCl-0005ej-At for qemu-devel@nongnu.org; Mon, 25 Jul 2011 09:28:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlLCk-0001tt-6N for qemu-devel@nongnu.org; Mon, 25 Jul 2011 09:28:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlLCj-0001tf-Sp for qemu-devel@nongnu.org; Mon, 25 Jul 2011 09:28:18 -0400 Message-ID: <4E2D6F6C.5070301@redhat.com> Date: Mon, 25 Jul 2011 16:28:12 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> <4E2D6A97.9050606@codemonkey.ws> <4E2D6C45.5030308@redhat.com> <20110725131728.GD4404@redhat.com> In-Reply-To: <20110725131728.GD4404@redhat.com> Content-Type: text/plain; charset=windows-1255; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/25/2011 04:17 PM, Gleb Natapov wrote: > On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: > > On 07/25/2011 04:07 PM, Anthony Liguori wrote: > > >On 07/20/2011 11:50 AM, Avi Kivity wrote: > > >>The current implementation of PAM and the PCI holes is broken in s= everal > > >>ways: > > >> > > >> - PCI BARs are not restricted to the PCI hole (a BAR may hide = memory) > > > > > >Technically, a BAR can be mapped to any non-RAM memory location. > > > > I understood TOM (Top Of Memory) to be fixed - can't find a register > > for it - but maybe I misread the spec. > > > PIIX3 spec: > > 2.2.11. TOM=97TOP OF MEMORY REGISTER (Function 0) > Address Offset: 69h > Default Value: 02h > Attribute: Read/Write > What's it doing in PIIX3? Is it the same TOM? --=20 error compiling committee.c: too many arguments to function