From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 2/6] arm: davinci: Explicitly set channel controllers' default queues Date: Mon, 25 Jul 2011 17:33:45 +0400 Message-ID: <4E2D70B9.7060202@mvista.com> References: <1310303679-17936-1-git-send-email-ido@wizery.com> <1310303679-17936-3-git-send-email-ido@wizery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:32783 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212Ab1GYNfj (ORCPT ); Mon, 25 Jul 2011 09:35:39 -0400 Received: by wwe5 with SMTP id 5so4078119wwe.1 for ; Mon, 25 Jul 2011 06:35:38 -0700 (PDT) In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: "Nori, Sekhar" Cc: Ido Yariv , "davinci-linux-open-source@linux.davincidsp.com" , "linux-arm-kernel@lists.infradead.org" , "linux-mmc@vger.kernel.org" Hello. Nori, Sekhar wrote: >> Davinci platforms may define a default queue for each channel >> controller. If one is not defined, the default queue is set to EVENTQ_1. >> However, there's no way to distinguish between an unset default queue to >> one that is set to EVENTQ_0, as EVENTQ_0 = 0. >> Explicitly specify the default queue for all channel controllers on all >> Davinci platforms to EVENTQ_1, and don't overwrite it in the EDMA probe >> function. >> One exception is the DA850 board, for which EVENTQ_1 is not a valid >> option for its second channel controller. Use EVENTQ_0 instead for that >> channel controller. >> Signed-off-by: Ido Yariv > Looks good to me. Will queue for v3.2/fixes Why wait for 3.2? If this is considered a fix, it should be applied to 3.1, no? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Mon, 25 Jul 2011 17:33:45 +0400 Subject: [PATCH v2 2/6] arm: davinci: Explicitly set channel controllers' default queues In-Reply-To: References: <1310303679-17936-1-git-send-email-ido@wizery.com> <1310303679-17936-3-git-send-email-ido@wizery.com> Message-ID: <4E2D70B9.7060202@mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. Nori, Sekhar wrote: >> Davinci platforms may define a default queue for each channel >> controller. If one is not defined, the default queue is set to EVENTQ_1. >> However, there's no way to distinguish between an unset default queue to >> one that is set to EVENTQ_0, as EVENTQ_0 = 0. >> Explicitly specify the default queue for all channel controllers on all >> Davinci platforms to EVENTQ_1, and don't overwrite it in the EDMA probe >> function. >> One exception is the DA850 board, for which EVENTQ_1 is not a valid >> option for its second channel controller. Use EVENTQ_0 instead for that >> channel controller. >> Signed-off-by: Ido Yariv > Looks good to me. Will queue for v3.2/fixes Why wait for 3.2? If this is considered a fix, it should be applied to 3.1, no? WBR, Sergei