From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v5 86/86] 440fx: fix PAM, PCI holes Date: Tue, 26 Jul 2011 11:01:04 +0300 Message-ID: <4E2E7440.3080208@redhat.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Eric Northup Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 07/26/2011 12:34 AM, Eric Northup wrote: > On Wed, Jul 20, 2011 at 9:50 AM, Avi Kivity wrote: > [...] > > @@ -130,7 +137,13 @@ static void pc_init1(MemoryRegion *system_memory, > > > > if (pci_enabled) { > > pci_bus = i440fx_init(&i440fx_state,&piix3_devfn, isa_irq, > > - system_memory, system_io, ram_size); > > + system_memory, system_io, ram_size, > > + 0xe0000000, 0x1fe00000, > > + 0x100000000 + above_4g_mem_size, > > + (sizeof(target_phys_addr_t) == 32 > > sizeof(target_phys_addr_t) == 8 ? Good catch. Fixed (== 4). -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlcZk-0007r0-DB for qemu-devel@nongnu.org; Tue, 26 Jul 2011 04:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlcZj-0007f1-EK for qemu-devel@nongnu.org; Tue, 26 Jul 2011 04:01:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlcZi-0007en-VB for qemu-devel@nongnu.org; Tue, 26 Jul 2011 04:01:11 -0400 Message-ID: <4E2E7440.3080208@redhat.com> Date: Tue, 26 Jul 2011 11:01:04 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-87-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Northup Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/26/2011 12:34 AM, Eric Northup wrote: > On Wed, Jul 20, 2011 at 9:50 AM, Avi Kivity wrote: > [...] > > @@ -130,7 +137,13 @@ static void pc_init1(MemoryRegion *system_memory, > > > > if (pci_enabled) { > > pci_bus = i440fx_init(&i440fx_state,&piix3_devfn, isa_irq, > > - system_memory, system_io, ram_size); > > + system_memory, system_io, ram_size, > > + 0xe0000000, 0x1fe00000, > > + 0x100000000 + above_4g_mem_size, > > + (sizeof(target_phys_addr_t) == 32 > > sizeof(target_phys_addr_t) == 8 ? Good catch. Fixed (== 4). -- error compiling committee.c: too many arguments to function