From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Schwarz <simonschwarzcor@googlemail.com>
Date: Tue, 26 Jul 2011 14:34:58 +0200
Subject: [U-Boot] [PATCH V3 5/5] devkit8000: Add nand-spl support for
 new SPL
In-Reply-To: <4E2E9A2B.5030406@gmail.com>
References: <1311617138-17041-1-git-send-email-simonschwarzcor@gmail.com>
	<1311675739-10966-1-git-send-email-simonschwarzcor@gmail.com>
	<1311675739-10966-6-git-send-email-simonschwarzcor@gmail.com>
	<4E2E9A2B.5030406@gmail.com>
Message-ID: <4E2EB472.2020605@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Andreas,

On 07/26/2011 12:42 PM, Andreas Bie?mann wrote:
> Dear Simon,
>

<snip>

>> diff --git a/board/timll/devkit8000/devkit8000.c b/board/timll/devkit8000/devkit8000.c
>> index 95afaaa..9b53742 100644
>> --- a/board/timll/devkit8000/devkit8000.c
>> +++ b/board/timll/devkit8000/devkit8000.c
>> @@ -119,7 +119,7 @@ void set_muxconf_regs(void)
>>   	MUX_DEVKIT8000();
>>   }
>>
>> -#ifdef CONFIG_DRIVER_DM9000
>> +#if defined(CONFIG_DRIVER_DM9000)&  !defined(CONFIG_SPL_BUILD)
>>   /*
>>    * Routine: board_eth_init
>>    * Description: Setting up the Ethernet hardware.
>> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
>> index 125c690..22c9b8e 100644
>> --- a/include/configs/devkit8000.h
>> +++ b/include/configs/devkit8000.h
>> @@ -307,4 +307,50 @@
>>   		                                         CONFIG_SYS_INIT_RAM_SIZE - \
>>   		                                         GENERATED_GBL_DATA_SIZE)
>>
>> +/* SRAM config */
>> +#define CONFIG_SYS_SRAM_START              0x40200000
>> +#define CONFIG_SYS_SRAM_SIZE               0xFFFF
>
> you mentioned this as 'Changed' in your reply to my last review. It is
> still unchanged (but comment about 64kB removed, so is the size not 64kB?).

Sorry, my mistake. NOW corrected in V4.

> regards
>
> Andreas Bie?mann

Regards
Simon