From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43571)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Qlj3L-0007Ic-9M
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 10:56:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Qlj3J-00015Y-Pt
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 10:56:11 -0400
Received: from e7.ny.us.ibm.com ([32.97.182.137]:55803)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1Qlj3J-00015Q-Ki
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 10:56:09 -0400
Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237])
	by e7.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6QEUUpd023330
	for <qemu-devel@nongnu.org>; Tue, 26 Jul 2011 10:30:30 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p6QEspJF122422
	for <qemu-devel@nongnu.org>; Tue, 26 Jul 2011 10:54:51 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p6QEsmox022822
	for <qemu-devel@nongnu.org>; Tue, 26 Jul 2011 10:54:48 -0400
Message-ID: <4E2ED538.5050200@linux.vnet.ibm.com>
Date: Tue, 26 Jul 2011 10:54:48 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <cover.1310400716.git.quintela@redhat.com>
	<3f56b8e8461282d8942c88b616c09907854f8b23.1310400716.git.quintela@redhat.com>
In-Reply-To: <3f56b8e8461282d8942c88b616c09907854f8b23.1310400716.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/11/2011 12:15 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela<quintela@redhat.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

Been pointed to this patch after having posted the same.

    Stefan

> ---
>   xen-mapcache.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/xen-mapcache.c b/xen-mapcache.c
> index fac47cd..e2e324d 100644
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, u
>
>   ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
>   {
> -    MapCacheEntry *entry = NULL, *pentry = NULL;
> +    MapCacheEntry *entry = NULL;
>       MapCacheRev *reventry;
>       target_phys_addr_t paddr_index;
>       target_phys_addr_t size;
> @@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
>
>       entry =&mapcache->entry[paddr_index % mapcache->nr_buckets];
>       while (entry&&  (entry->paddr_index != paddr_index || entry->size != size)) {
> -        pentry = entry;
>           entry = entry->next;
>       }
>       if (!entry) {