From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Schwarz <simonschwarzcor@googlemail.com>
Date: Thu, 28 Jul 2011 14:54:42 +0200
Subject: [U-Boot] [PATCH V6 2/5] omap-common: add nand spl support
In-Reply-To: <4E3132BF.3060306@ti.com>
References: <1311771039-31691-1-git-send-email-simonschwarzcor@gmail.com>	<1311842291-24837-1-git-send-email-simonschwarzcor@gmail.com>
	<1311842291-24837-3-git-send-email-simonschwarzcor@gmail.com>
	<4E3132BF.3060306@ti.com>
Message-ID: <4E315C12.1090702@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Aneesh,

On 07/28/2011 11:58 AM, Aneesh V wrote:
> Hi Simon,
>
> On Thursday 28 July 2011 02:08 PM, Simon Schwarz wrote:
> [snip ..]
>> +
>> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +{
>> + debug("resetting cpu...");
>> + reset_cpu(0);
>> +
>> + return 0;
>> +}
>
> Can you explain the need of this do_reset()? I couldn't figure out
> where it is used in SPL.

Thats odd. I added this because of vsprintf - this calls do_reset() 
which is not included in the SPL. This was in an early stage of SPL and 
OMAP4 patches. Seems this is not needed anymore: will delete it for the 
next version.

> br,
> Aneesh

Regards & thx for the review!
Simon