From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Fri, 29 Jul 2011 16:32:45 +0400 Subject: [U-Boot] [PATCH] cfb_console: fix build breakage In-Reply-To: <1311923413-62087-1-git-send-email-andreas.devel@googlemail.com> References: <1311923413-62087-1-git-send-email-andreas.devel@googlemail.com> Message-ID: <4E32A86D.1010701@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 29-07-2011 11:10, Andreas Bie?mann wrote: > Commit 09c2e90c110ef99f1203685acd1059114a51b167 "unify version_string" > introduced a build breakage in cfb_console.c > ---8<--- > cfb_console.c:1497: warning: format '%s' expects type 'char *', but > argument 3 has type 'const char (*)[]' > --->8--- > Signed-off-by: Andreas Bie?mann > --- > drivers/video/cfb_console.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c > index 77e7285..b56197f 100644 > --- a/drivers/video/cfb_console.c > +++ b/drivers/video/cfb_console.c > @@ -1494,7 +1494,7 @@ static void *video_logo (void) > > logo_plot (video_fb_address, VIDEO_COLS, 0, 0); > > - sprintf (info, " %s",&version_string); > + sprintf (info, " %s", version_string); This wouldn't pass checkpatch.pl -- remove the space before paren. WBR, Sergei