From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989Ab1HBTaw (ORCPT ); Tue, 2 Aug 2011 15:30:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43116 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153Ab1HBTaq (ORCPT ); Tue, 2 Aug 2011 15:30:46 -0400 Message-ID: <4E38510B.6090001@suse.cz> Date: Tue, 02 Aug 2011 21:33:31 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 MIME-Version: 1.0 To: Sam Ravnborg Cc: Arnaud Lacombe , linux-kbuild@vger.kernel.org, xiyou.wangcong@gmail.com, rdunlap@xenotime.net, linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com Subject: Re: [PATCH] kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE() References: <1311634718-32588-1-git-send-email-mmarek@suse.cz> <1311947497-4958-1-git-send-email-mmarek@suse.cz> <20110802173343.GA5251@merkur.ravnborg.org> <20110802192610.GA5338@merkur.ravnborg.org> In-Reply-To: <20110802192610.GA5338@merkur.ravnborg.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 2.8.2011 21:26, Sam Ravnborg napsal(a): >>> >>> If we do it like this then how about adding this to autoconf.h and avoid the extra file, >>> and the extra flag to gcc? >>> >> That would be intrusive for non-Linux users of kconfig. You would have >> to hardcode a in autoconf.h, which mean other >> project would have to either mirror the Linux include tree structure, >> or modify kconfig for the desired include path, if the feature is >> desired at all. As I see it, Linux, through Kbuild, is a user of >> kconfig. > The idea was to entirely skip kconfig.h - and include the code in > autoconf.h verbatim - so no extra file. We could do that. I went for the extra file because it was easier to edit a .h file than to edit a .c file that generates a .h file :). Michal