From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QpEo1-0006My-Qm
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 03:26:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QpEo0-0001it-P2
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 03:26:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QpEo0-0001in-GT
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 03:26:52 -0400
Message-ID: <4E3B9BE4.3020807@redhat.com>
Date: Fri, 05 Aug 2011 09:29:40 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <alpine.LNX.2.00.1108051019170.14809@linmac>
In-Reply-To: <alpine.LNX.2.00.1108051019170.14809@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Build broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Am 05.08.2011 08:22, schrieb malc:
> 
> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine_new':
> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' may be used uninitialized in this function
> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:136:18: note: 'arg.i[1]' was declared here
> 
> diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c
> index 41c2379..42dc3e2 100644
> --- a/coroutine-ucontext.c
> +++ b/coroutine-ucontext.c
> @@ -133,7 +133,7 @@ static Coroutine *coroutine_new(void)
>      CoroutineUContext *co;
>      ucontext_t old_uc, uc;
>      jmp_buf old_env;
> -    union cc_arg arg;
> +    union cc_arg arg = {0};
>  
>      /* The ucontext functions preserve signal masks which incurs a system call
>       * overhead.  setjmp()/longjmp() does not preserve signal masks but only
> 
> I guess gcc should yell not only here on ppc32 but on any machine where
> pointer size is less than the size of two ints.

Stefan, why does this code even exist again? I think at some point I had
it changed to just use a static variable in order to avoid doing this
kind of tricks with unions.

Interestingly, the buildbot doesn't seem to have failed on i386.

Kevin