From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
Date: Fri, 05 Aug 2011 10:19:25 -0700 [thread overview]
Message-ID: <4E3C261D.5020702@gmail.com> (raw)
In-Reply-To: <CABcZANkf_xBxAfs584Mo7370oLO8ggyy0BMQPfBy-dFN-qkWpA@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/04/2011 09:59 PM, Chris Larson wrote:
> On Wed, Aug 3, 2011 at 2:54 PM, Daniel Lazzari
> <dlazzari@leapfrog.com> wrote:
>> Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
>> instead of lazily appending it with _append. This fixes a bug
>> where the wrong cache was cleared when BB_SRCREV_POLICY = "clear".
>>
>>
>> Signed-off-by: Daniel Lazzari Jr <dlazzari@leapfrog.com> ---
>> meta/conf/distro/defaultsetup.conf | 2 +- 1 files changed, 1
>> insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/conf/distro/defaultsetup.conf
>> b/meta/conf/distro/defaultsetup.conf index 072f03c..951e5be 100644
>> --- a/meta/conf/distro/defaultsetup.conf +++
>> b/meta/conf/distro/defaultsetup.conf @@ -14,7 +14,7 @@ require
>> conf/distro/include/tclibc-${TCLIBC}.inc
>>
>> # Allow single libc distros to disable this code TCLIBCAPPEND ?=
>> "-${TCLIBC}" -TMPDIR_append = "${TCLIBCAPPEND}" +TMPDIR :=
>> "${TMPDIR}${TCLIBCAPPEND}"
>>
>> CACHE = "${TMPDIR}/cache/${TCMODE}-${TCLIBC}${@['', '/' +
>> str(bb.data.getVar('MACHINE', d,
>> 1))][bool(bb.data.getVar('MACHINE', d, 1))]}${@['', '/' +
>> str(bb.data.getVar('SDKMACHINE', d,
>> 1))][bool(bb.data.getVar('SDKMACHINE', d, 1))]}"
>
> If all you want is an immediate concatenation, you can use .=. Using
> := like this forces an early expansion of TMPDIR unnecessarily, as
> far as I can tell.
I think you mean TMPDIR .= "${TCLIBCAPPEND}" ?
I think that will work too. I have tested the original patch too and it
has worked ok but .= would be better I think let me try that as well.
- --
- -Khem
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk48Jh0ACgkQuwUzVZGdMxT+FwCfcQ38C1x6DlSYtnLIlC0ov2aY
ZHYAn3SfzV483FUFCVdTZX67MJQQBZdw
=bUgM
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2011-08-05 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 21:54 [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf Daniel Lazzari
2011-08-05 4:59 ` Chris Larson
2011-08-05 17:19 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3C261D.5020702@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.