From: Jarod Wilson <jarod@redhat.com>
To: Anssi Hannula <anssi.hannula@iki.fi>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-media@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RF remote
Date: Mon, 08 Aug 2011 11:57:33 -0400 [thread overview]
Message-ID: <4E40076D.2030303@redhat.com> (raw)
In-Reply-To: <4E3FF355.6090807@iki.fi>
Anssi Hannula wrote:
> On 08.08.2011 08:57, Dmitry Torokhov wrote:
>> On Sun, Aug 07, 2011 at 01:18:11AM +0300, Anssi Hannula wrote:
>>> Add keymap for the Medion X10 RF remote which uses the ati_remote
>>> driver, and default to it based on the usb id.
>> Since rc-core supports loading custom keytmaps should we ass medion
>> keymap here?
>>
>> I think we should keep the original keymap to avoid regressions, but new
>> keymaps should be offloaded to udev.
>
> Well, I simply followed the convention, as all other remotes under
> media/ have the default table in-kernel.
>
> I'm not against putting it off-kernel, but in that case the same should
> be done for all new media devices. Is that the plan?
That's the long-term plan, but not every distro has a sufficiently new
enough v4l-utils and ir-keytable with udev rules to load keymaps, so
we've been adding default remotes in-kernel and userspace (effectively
meaning duplicated keymap loads if the user does have ir-keytable with
udev rules, but meh). I'd say add it for now, and when we get to the
point of v4l-utils ubiquity, we can drop this along with all the other
in-kernel rc keymaps.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2011-08-08 15:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 10:41 [PATCH 0/1] Input: ati_remote - extend keytable for medion remotes Jan Losinski
2011-04-18 10:45 ` [PATCH 1/1] " Jan Losinski
2011-05-19 8:54 ` Jan Losinski
2011-05-25 16:32 ` Dmitry Torokhov
2011-07-01 14:01 ` Steffen Barszus
2011-08-06 15:32 ` Steffen Barszus
2011-08-06 21:31 ` Anssi Hannula
2011-08-06 22:18 ` [PATCH 0/7] ati_remote: move to rc-core and other updates Anssi Hannula
2011-08-06 22:18 ` [PATCH 1/7] [media] move ati_remote driver from input/misc to media/rc Anssi Hannula
2011-08-06 22:18 ` [PATCH 2/7] [media] ati_remote: migrate to the rc subsystem Anssi Hannula
2011-08-06 22:18 ` Anssi Hannula
2011-08-06 22:18 ` [PATCH 3/7] [media] ati_remote: parent input devices to usb interface Anssi Hannula
2011-08-06 22:18 ` [PATCH 4/7] [media] ati_remote: fix check for a weird byte Anssi Hannula
2011-08-06 22:18 ` [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RF remote Anssi Hannula
2011-08-08 5:57 ` Dmitry Torokhov
2011-08-08 5:57 ` Dmitry Torokhov
2011-08-08 14:31 ` Anssi Hannula
2011-08-08 14:31 ` Anssi Hannula
2011-08-08 15:57 ` Jarod Wilson [this message]
2011-08-06 22:18 ` [PATCH 6/7] [media] ati_remote: add support for SnapStream Firefly remote Anssi Hannula
2011-08-06 22:18 ` [PATCH 7/7] [media] ati_remote: update Kconfig description Anssi Hannula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E40076D.2030303@redhat.com \
--to=jarod@redhat.com \
--cc=anssi.hannula@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.