All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tabi Timur-B04825 <B04825@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [Patch v2] powerpc/eeprom: cleanup mac command
Date: Thu, 11 Aug 2011 01:27:28 +0000	[thread overview]
Message-ID: <4E432FFE.9040308@freescale.com> (raw)
In-Reply-To: <1312988191-26950-1-git-send-email-yorksun@freescale.com>

York Sun wrote:
> Change the help message to be more helpful. Print argument format.
> Fix MAX_NUM_PORTS to comply with v1 NXID format.
>
> Signed-off-by: York Sun<yorksun@freescale.com>

Could you also fix the commands so that they take a number in decimal 
instead of hex?


         e.mac[index][i] = simple_strtoul(p, &p, 16);

...

	e.mac_count = simple_strtoul(argv[2], NULL, 16);

I know U-Boot uses hex for everything, but it doesn't make sense for 
this command.

  reply	other threads:[~2011-08-11  1:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 14:56 [U-Boot] [Patch v2] powerpc/eeprom: cleanup mac command York Sun
2011-08-11  1:27 ` Tabi Timur-B04825 [this message]
2011-08-11  1:34   ` [U-Boot] [u-boot-release] " Mike Frysinger
2011-08-11 14:35   ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E432FFE.9040308@freescale.com \
    --to=b04825@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.