All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hong Xu <hong.xu@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] ARM: Clean arch/arm/lib/cache.c
Date: Mon, 15 Aug 2011 15:00:59 +0800	[thread overview]
Message-ID: <4E48C42B.5050906@atmel.com> (raw)
In-Reply-To: <201108110638.50692.marek.vasut@gmail.com>

Hi Marek,

On 08/11/2011 12:38 PM, Marek Vasut wrote:
> On Thursday, August 11, 2011 04:19:45 AM Hong Xu wrote:
>> The default cache operations defined in arch/arm/lib/cache.c
>> do not perform any real cache operation, and instead a WARNING
>> will be emitted.
>>
>> Signed-off-by: Hong Xu<hong.xu@atmel.com>
>> Tested-by: Elen Song<elen.song@atmel.com>
>> CC: Albert Aribaud<albert.u.boot@aribaud.net>
>> CC: Aneesh V<aneesh@ti.com>
>> CC: Marek Vasut<marek.vasut@gmail.com>
>> CC: Reinhard Meyer<u-boot@emk-elektronik.de>
>> CC: Heiko Schocher<hs@denx.de>
>> ---
>>   arch/arm/lib/cache.c |   55
>> ++++++++++++++++++++++++++++--------------------- 1 files changed, 31
>> insertions(+), 24 deletions(-)
>>
>> diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c
>> index 92b61a2..6af05ec 100644
>> --- a/arch/arm/lib/cache.c
>> +++ b/arch/arm/lib/cache.c
>> @@ -20,36 +20,43 @@
>>    * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>>    * MA 02111-1307 USA
>>    */
>> +#include<linux/compiler.h>
>> +#include<common.h>
>>
>> -/* for now: just dummy functions to satisfy the linker */
>> +#define EMIT_WARNING printf("WARNING: %s - CPU cache operation is not " \
>> +"implemented!\n", __func__)
>
> Maybe use debug() ? Or make the emission of warning conditional, somehow I have
> the feeling this will make some people unhappy.

Just my feelings: It's noisy but it'll give strong message to the user 
even if the DEBUG is not opened :-)

BR,
Eric

> Otherwise looks nice and clean.
>>
>> -#include<common.h>
>> +/*

[...]

  reply	other threads:[~2011-08-15  7:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11  2:19 [U-Boot] [PATCH 0/3] ARM: Clean arm/lib/cache.c, modify ARM1136 and ARM926 accordingly Hong Xu
2011-08-11  2:19 ` [U-Boot] [PATCH 1/3] ARM: Clean arch/arm/lib/cache.c Hong Xu
2011-08-11  2:19 ` Hong Xu
2011-08-11  4:38   ` Marek Vasut
2011-08-15  7:00     ` Hong Xu [this message]
2011-08-15  8:08       ` Marek Vasut
2011-08-11  2:19 ` [U-Boot] [PATCH 2/3] ARM: ARM1136 - Remove flush_cache from arch/arm/lib/cache.c Hong Xu
2011-08-11  2:19 ` Hong Xu
2011-08-11  4:40   ` Marek Vasut
2011-08-15  7:04     ` Hong Xu
2011-08-15  8:09       ` Marek Vasut
2011-10-06 22:00   ` Wolfgang Denk
2011-08-11  2:19 ` [U-Boot] [PATCH 3/3] ARM: ARM926EJS - Add cache operations Hong Xu
2011-08-11  2:19 ` Hong Xu
2011-08-11  4:35 ` [U-Boot] [PATCH 0/3] ARM: Clean arm/lib/cache.c, modify ARM1136 and ARM926 accordingly Marek Vasut
2011-08-18 10:51 ` Marek Vasut
2011-08-19  8:39   ` Hong Xu
2011-08-19  9:33     ` Marek Vasut
2011-10-21 20:44 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E48C42B.5050906@atmel.com \
    --to=hong.xu@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.