From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Schmidt Subject: Re: [PATCH] bnx2x: suppress repeated error messages about Max BW Date: Mon, 15 Aug 2011 13:59:26 +0200 Message-ID: <4E490A1E.3060209@redhat.com> References: <20110812143324.5740.45824.stgit@dhcp-29-224.brq.redhat.com> <1313405680.31417.6.camel@lb-tlvb-eilong.il.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , Dmitry Kravkov , Vladislav Zolotarov To: eilong@broadcom.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56523 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007Ab1HOL7a (ORCPT ); Mon, 15 Aug 2011 07:59:30 -0400 In-Reply-To: <1313405680.31417.6.camel@lb-tlvb-eilong.il.broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 08/15/2011 12:54 PM, Eilon Greenstein wrote: > On Fri, 2011-08-12 at 07:33 -0700, Michal Schmidt wrote: >> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h >> index c423504..648e165 100644 >> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h >> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h >> @@ -1220,6 +1220,7 @@ struct bnx2x { >> struct cmng_struct_per_port cmng; >> u32 vn_weight_sum; >> u32 mf_config[E1HVN_MAX]; >> + bool prev_max_cfg_invalid[E1HVN_MAX]; > The warning is always for the current VN, so if you insist on showing a > warning only once on a board with invalid configuration, you can use a > single boolean. bnx2x_cmng_fns_init() iterates over VNs: for (vn = VN_0; vn < E1HVN_MAX; vn++) bnx2x_init_vn_minmax(bp, vn); and bnx2x_init_vn_minmax() calls bnx2x_extract_max_cfg() on the given VN, so it seems that the warning can be produced for a non-current VN. Michal