From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Thu, 18 Aug 2011 09:20:49 +0300 Subject: [U-Boot] [PATCH 3/9] apf9328: Add Armadeus Project board APF9328 In-Reply-To: References: <20110810200828.21204.60050.stgit@shuttle2.etheralp.ch> <20110810203315.21204.35859.stgit@shuttle2.etheralp.ch> <4E4397E4.60304@denx.de> <5408A6F6-0115-4DB3-BFF4-4D7616487C4E@armadeus.org> <4E44CCF1.9030007@denx.de> <4E4B6E37.4020402@compulab.co.il> Message-ID: <4E4CAF41.4090901@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/18/11 00:58, Eric Jarrige wrote: > Hi Higor, Hi Stefano, > > On 17 ao?t 2011, at 09:31, Igor Grinberg wrote: > >> On 08/12/11 09:49, Stefano Babic wrote: >>> On 08/12/2011 01:41 AM, Eric Jarrige wrote: >>> >>> Hi Eric, >>> >>>>>> +int board_init(void) +{ + gd->bd->bi_arch_number = >>>>>> CONFIG_MACH_TYPE; >>>>> Is there no MACH_TYPE for this board ? It is uncommon for an ARM >>>>> board. Should this board run Linux ? >>>> The MACH_TYPE for this board is 906. This board runs linux and the >>>> integration in linux is on going. >>> Ok, I have understood. The only thing you can directly set >>> MACH_TYPE_APF9328 here. IMHO it is more readable. >> You should not do this here unless you support multiple mach types in a single file. >> Please, see the CONFIG_MACH_TYPE in the U-Boot documentation (README file). > Here is the README sentence regarding CONFIG_MACH_TYPE: > >> CONFIG_MACH_TYPE [relevant for ARM only][mandatory] >> >> This setting is mandatory for all boards that have only one >> machine type and must be used to specify the machine type >> number as it appears in the ARM machine registry >> (see http://www.arm.linux.org.uk/developer/machines/). >> Only boards that have multiple machine types supported >> in a single configuration file and the machine type is >> runtime discoverable, do not have to use this setting. > My understanding is: > 1) CONFIG_MACH_TYPE has to be defined in apf9328.h > 2) as gd->bd->bi_arch_number is already initialize in board.c i should completely remove this second initialization from the apf9382.c Right. Just remove that line. -- Regards, Igor.