From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm PCI assignment & VFIO ramblings Date: Mon, 22 Aug 2011 16:06:07 +0300 Message-ID: <4E52543F.70104@redhat.com> References: <20110803020422.GF29719@yookeroo.fritz.box> <4E3F9E33.5000706@redhat.com> <1312932258.4524.55.camel@bling.home> <1312944513.29273.28.camel@pasglop> <1313859105.6866.192.camel@x201.home> <4E51F782.7060005@redhat.com> <20110822104635.GC2079@amd.com> <4E5234B7.7000700@redhat.com> <20110822123651.GD2079@amd.com> <4E524EBB.8090603@redhat.com> <20110822125502.GF2079@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alex Williamson , chrisw , Alexey Kardashevskiy , "kvm@vger.kernel.org" , Paul Mackerras , Benjamin Herrenschmidt , qemu-devel , iommu , Anthony Liguori , "linux-pci@vger.kernel.org" , linuxppc-dev , "benve@cisco.com" To: "Roedel, Joerg" Return-path: In-Reply-To: <20110822125502.GF2079@amd.com> Sender: linux-pci-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/22/2011 03:55 PM, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: > > On 08/22/2011 03:36 PM, Roedel, Joerg wrote: > > > On the AMD IOMMU side this information is stored in the IVRS ACPI table. > > > Not sure about the VT-d side, though. > > > > I see. There is no sysfs node representing it? > > No. It also doesn't exist as a 'struct pci_dev'. This caused problems in > the AMD IOMMU driver in the past and I needed to fix that. There I know > that from :) Well, too bad. > > > I'd rather not add another meaningless identifier. > > Well, I don't think its really meaningless, but we need some way to > communicate the information about device groups to userspace. > I mean the contents of the group descriptor. There are enough 42s in the kernel, it's better if we can replace a synthetic number with something meaningful. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by ozlabs.org (Postfix) with ESMTP id CB7B6B6F68 for ; Mon, 22 Aug 2011 23:06:51 +1000 (EST) Message-ID: <4E52543F.70104@redhat.com> Date: Mon, 22 Aug 2011 16:06:07 +0300 From: Avi Kivity MIME-Version: 1.0 To: "Roedel, Joerg" Subject: Re: kvm PCI assignment & VFIO ramblings References: <20110803020422.GF29719@yookeroo.fritz.box> <4E3F9E33.5000706@redhat.com> <1312932258.4524.55.camel@bling.home> <1312944513.29273.28.camel@pasglop> <1313859105.6866.192.camel@x201.home> <4E51F782.7060005@redhat.com> <20110822104635.GC2079@amd.com> <4E5234B7.7000700@redhat.com> <20110822123651.GD2079@amd.com> <4E524EBB.8090603@redhat.com> <20110822125502.GF2079@amd.com> In-Reply-To: <20110822125502.GF2079@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Alexey Kardashevskiy , "kvm@vger.kernel.org" , Paul Mackerras , qemu-devel , iommu , chrisw , Alex Williamson , Anthony Liguori , "linux-pci@vger.kernel.org" , linuxppc-dev , "benve@cisco.com" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/22/2011 03:55 PM, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: > > On 08/22/2011 03:36 PM, Roedel, Joerg wrote: > > > On the AMD IOMMU side this information is stored in the IVRS ACPI table. > > > Not sure about the VT-d side, though. > > > > I see. There is no sysfs node representing it? > > No. It also doesn't exist as a 'struct pci_dev'. This caused problems in > the AMD IOMMU driver in the past and I needed to fix that. There I know > that from :) Well, too bad. > > > I'd rather not add another meaningless identifier. > > Well, I don't think its really meaningless, but we need some way to > communicate the information about device groups to userspace. > I mean the contents of the group descriptor. There are enough 42s in the kernel, it's better if we can replace a synthetic number with something meaningful. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvUDV-0000Bm-Et for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:07:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvUDN-0007Xy-Nd for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:07:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvUDN-0007Xo-Ef for qemu-devel@nongnu.org; Mon, 22 Aug 2011 09:06:53 -0400 Message-ID: <4E52543F.70104@redhat.com> Date: Mon, 22 Aug 2011 16:06:07 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20110803020422.GF29719@yookeroo.fritz.box> <4E3F9E33.5000706@redhat.com> <1312932258.4524.55.camel@bling.home> <1312944513.29273.28.camel@pasglop> <1313859105.6866.192.camel@x201.home> <4E51F782.7060005@redhat.com> <20110822104635.GC2079@amd.com> <4E5234B7.7000700@redhat.com> <20110822123651.GD2079@amd.com> <4E524EBB.8090603@redhat.com> <20110822125502.GF2079@amd.com> In-Reply-To: <20110822125502.GF2079@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Roedel, Joerg" Cc: Alexey Kardashevskiy , "kvm@vger.kernel.org" , Paul Mackerras , qemu-devel , iommu , chrisw , Alex Williamson , "linux-pci@vger.kernel.org" , linuxppc-dev , "benve@cisco.com" On 08/22/2011 03:55 PM, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 08:42:35AM -0400, Avi Kivity wrote: > > On 08/22/2011 03:36 PM, Roedel, Joerg wrote: > > > On the AMD IOMMU side this information is stored in the IVRS ACPI table. > > > Not sure about the VT-d side, though. > > > > I see. There is no sysfs node representing it? > > No. It also doesn't exist as a 'struct pci_dev'. This caused problems in > the AMD IOMMU driver in the past and I needed to fix that. There I know > that from :) Well, too bad. > > > I'd rather not add another meaningless identifier. > > Well, I don't think its really meaningless, but we need some way to > communicate the information about device groups to userspace. > I mean the contents of the group descriptor. There are enough 42s in the kernel, it's better if we can replace a synthetic number with something meaningful. -- error compiling committee.c: too many arguments to function