From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Date: Tue, 23 Aug 2011 09:48:48 +0530 Message-ID: <4E532A28.60103@ti.com> References: <1312979122-5896-1-git-send-email-j-keerthy@ti.com> <1312979122-5896-7-git-send-email-j-keerthy@ti.com> <20110810124629.GJ12882@legolas.emea.dhcp.ti.com> <20110811103658.GG27742@legolas.emea.dhcp.ti.com> <20110811141248.GK28500@legolas.emea.dhcp.ti.com> <20110811185408.GB15970@legolas.emea.dhcp.ti.com> <20110811185558.GC15970@legolas.emea.dhcp.ti.com> <4E444B8F.9060908@ti.com> <4E449D65.9000004@ti.com> <874o19gfrr.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog116.obsmtp.com ([74.125.149.240]:59933 "EHLO na3sys009aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750698Ab1HWETF (ORCPT ); Tue, 23 Aug 2011 00:19:05 -0400 Received: by mail-gw0-f54.google.com with SMTP id 15so5530168gwb.27 for ; Mon, 22 Aug 2011 21:19:03 -0700 (PDT) In-Reply-To: <874o19gfrr.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Roger Quadros , balbi@ti.com, "J, KEERTHY" , Tony Lindgren , lm-sensors@lm-sensors.org, vishwanath.bs@ti.com, linux-omap@vger.kernel.org, b-cousson@ti.com, Russell King , Linux ARM Kernel Mailing List , khali@linux-fr.org, guenter.roeck@ericsson.com On 8/23/2011 5:28 AM, Kevin Hilman wrote: > Rajendra Nayak writes: > > [...] > >> FWIK, its a one time requirement to set the clock rate to the >> right rate the device can operate in based on what a platform >> supports. > > Except $SUBJECT patch hard-codes the clock rate for all platforms in the > driver. The device has a requirement to operate in a 1Mhz to 2Mhz range. So the driver is using a clk_round_rate() to get the closest rate supported and sets it using a clk_set_rate(). > > If the clock rate is to be platform-specific, it should be done in > platform-specific code. I am fine if this needs to be moved to platform-specific code, but I wasn't quite sure this needs to be done in clock framework as was suggested. > > Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: rnayak@ti.com (Rajendra Nayak) Date: Tue, 23 Aug 2011 09:48:48 +0530 Subject: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver In-Reply-To: <874o19gfrr.fsf@ti.com> References: <1312979122-5896-1-git-send-email-j-keerthy@ti.com> <1312979122-5896-7-git-send-email-j-keerthy@ti.com> <20110810124629.GJ12882@legolas.emea.dhcp.ti.com> <20110811103658.GG27742@legolas.emea.dhcp.ti.com> <20110811141248.GK28500@legolas.emea.dhcp.ti.com> <20110811185408.GB15970@legolas.emea.dhcp.ti.com> <20110811185558.GC15970@legolas.emea.dhcp.ti.com> <4E444B8F.9060908@ti.com> <4E449D65.9000004@ti.com> <874o19gfrr.fsf@ti.com> Message-ID: <4E532A28.60103@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 8/23/2011 5:28 AM, Kevin Hilman wrote: > Rajendra Nayak writes: > > [...] > >> FWIK, its a one time requirement to set the clock rate to the >> right rate the device can operate in based on what a platform >> supports. > > Except $SUBJECT patch hard-codes the clock rate for all platforms in the > driver. The device has a requirement to operate in a 1Mhz to 2Mhz range. So the driver is using a clk_round_rate() to get the closest rate supported and sets it using a clk_set_rate(). > > If the clock rate is to be platform-specific, it should be done in > platform-specific code. I am fine if this needs to be moved to platform-specific code, but I wasn't quite sure this needs to be done in clock framework as was suggested. > > Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Date: Tue, 23 Aug 2011 04:30:48 +0000 Subject: Re: [lm-sensors] [RFC PATCH 6/6] hwmon: OMAP4: On die temperature Message-Id: <4E532A28.60103@ti.com> List-Id: References: <1312979122-5896-1-git-send-email-j-keerthy@ti.com> <1312979122-5896-7-git-send-email-j-keerthy@ti.com> <20110810124629.GJ12882@legolas.emea.dhcp.ti.com> <20110811103658.GG27742@legolas.emea.dhcp.ti.com> <20110811141248.GK28500@legolas.emea.dhcp.ti.com> <20110811185408.GB15970@legolas.emea.dhcp.ti.com> <20110811185558.GC15970@legolas.emea.dhcp.ti.com> <4E444B8F.9060908@ti.com> <4E449D65.9000004@ti.com> <874o19gfrr.fsf@ti.com> In-Reply-To: <874o19gfrr.fsf@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kevin Hilman Cc: Roger Quadros , balbi@ti.com, "J, KEERTHY" , Tony Lindgren , lm-sensors@lm-sensors.org, vishwanath.bs@ti.com, linux-omap@vger.kernel.org, b-cousson@ti.com, Russell King , Linux ARM Kernel Mailing List , khali@linux-fr.org, guenter.roeck@ericsson.com On 8/23/2011 5:28 AM, Kevin Hilman wrote: > Rajendra Nayak writes: > > [...] > >> FWIK, its a one time requirement to set the clock rate to the >> right rate the device can operate in based on what a platform >> supports. > > Except $SUBJECT patch hard-codes the clock rate for all platforms in the > driver. The device has a requirement to operate in a 1Mhz to 2Mhz range. So the driver is using a clk_round_rate() to get the closest rate supported and sets it using a clk_set_rate(). > > If the clock rate is to be platform-specific, it should be done in > platform-specific code. I am fine if this needs to be moved to platform-specific code, but I wasn't quite sure this needs to be done in clock framework as was suggested. > > Kevin _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors