From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvlFC-0006RA-RQ for qemu-devel@nongnu.org; Tue, 23 Aug 2011 03:17:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvlFB-0005qZ-OT for qemu-devel@nongnu.org; Tue, 23 Aug 2011 03:17:54 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:60348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvlFB-0005qP-FU for qemu-devel@nongnu.org; Tue, 23 Aug 2011 03:17:53 -0400 Received: by wwf25 with SMTP id 25so5404824wwf.10 for ; Tue, 23 Aug 2011 00:17:52 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E53541E.1050803@redhat.com> Date: Tue, 23 Aug 2011 09:17:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4E5264B5.4010002@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Patrick Jackson On 08/22/2011 10:41 PM, Stefan Hajnoczi wrote: > On Mon, Aug 22, 2011 at 3:16 PM, Paolo Bonzini wrote: >> On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: >>> >>> Please use the block layer instead of reinventing portable file I/O. >>> >>> Also, please check which of the utility functions already exist in >>> QEMU. If a utility function in this patch is needed it should be made >>> generic for all of QEMU, not just goldfish or nand. >> >> This was part of the plans, but there was no time for it. > > Does that mean this series is Request For Comments and not something > you expect to be merged into qemu.git? Yes, more or less. Paolo