From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Ceresoli <luca.ceresoli@comelit.it>
Date: Wed, 24 Aug 2011 15:43:31 +0200
Subject: [U-Boot] [PATCH 2/9] OMAP3: DIG297: Use generic MMC driver
In-Reply-To: <1314051236-21740-3-git-send-email-trini@ti.com>
References: <1314051236-21740-1-git-send-email-trini@ti.com>
	<1314051236-21740-3-git-send-email-trini@ti.com>
Message-ID: <4E550003.4060005@comelit.it>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Tom Rini wrote:
> Switch from the legacy omap3 mmc driver to the new generic omap hsmmc
> driver.  This patch is based on the work done for Beagle, etc.
>
> Signed-off-by: Tom Rini<trini@ti.com>

Again, please Cc: the board maintainers in the future, thanks.

> ---
>   board/comelit/dig297/dig297.c |    9 +++++++++
>   include/configs/dig297.h      |    5 +++--
>   2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/board/comelit/dig297/dig297.c b/board/comelit/dig297/dig297.c
> index 0062f12..a7071cd 100644
> --- a/board/comelit/dig297/dig297.c
> +++ b/board/comelit/dig297/dig297.c
> @@ -37,6 +37,7 @@
>   #include<netdev.h>
>   #include<twl4030.h>
>   #include<asm/io.h>
> +#include<asm/arch/mmc_host_def.h>
>   #include<asm/arch/omap3-regs.h>
>   #include<asm/arch/mux.h>
>   #include<asm/arch/mem.h>
> @@ -145,6 +146,14 @@ void set_muxconf_regs(void)
>   	MUX_DIG297();
>   }
>
> +#ifdef CONFIG_GENERIC_MMC
> +int board_mmc_init(bd_t *bis)
> +{
> +	omap_mmc_init(0);
> +	return 0;
> +}
> +#endif
> +
>   #ifdef CONFIG_CMD_NET
>   /*
>    * Routine: setup_net_chip
> diff --git a/include/configs/dig297.h b/include/configs/dig297.h
> index b68f073..0e05df3 100644
> --- a/include/configs/dig297.h
> +++ b/include/configs/dig297.h
> @@ -97,8 +97,9 @@
>   #define CONFIG_BAUDRATE			115200
>   #define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
>   					115200}
> -#define CONFIG_MMC
> -#define CONFIG_OMAP3_MMC
> +#define CONFIG_GENERIC_MMC		1
> +#define CONFIG_MMC			1
> +#define CONFIG_OMAP_HSMMC		1

IIRC the coding style says you should define the y/n constants without
a value, e.g.:
   #define CONFIG_GENERIC_MMC
not:
   #define CONFIG_GENERIC_MMC 1

Apart for this:
Tested-by: Luca Ceresoli <luca.ceresoli@comelit.it>

Luca