* [libnl-nft PATCH] Fix the route object comparison using the wrong pointer
@ 2011-08-24 16:22 Thomas Jarosch
2011-09-30 11:26 ` Thomas Jarosch
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Jarosch @ 2011-08-24 16:22 UTC (permalink / raw)
To: netfilter-devel
Typo detected by cppcheck
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
lib/route/route_obj.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/route/route_obj.c b/lib/route/route_obj.c
index 4e14d6d..8f1d4d5 100644
--- a/lib/route/route_obj.c
+++ b/lib/route/route_obj.c
@@ -403,7 +403,7 @@ static int route_compare(struct nl_object *_a, struct nl_object *_b,
diff |= ROUTE_DIFF(FLAGS,
(a->rt_flags ^ b->rt_flags) & b->rt_flag_mask);
} else {
- if (a->rt_nr_nh != a->rt_nr_nh)
+ if (a->rt_nr_nh != b->rt_nr_nh)
goto nh_mismatch;
/* search for a dup in each nh of a */
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [libnl-nft PATCH] Fix the route object comparison using the wrong pointer
2011-08-24 16:22 [libnl-nft PATCH] Fix the route object comparison using the wrong pointer Thomas Jarosch
@ 2011-09-30 11:26 ` Thomas Jarosch
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Jarosch @ 2011-09-30 11:26 UTC (permalink / raw)
To: netfilter-devel; +Cc: Patrick McHardy
On Wednesday, 24. August 2011 18:22:55 you wrote:
> Typo detected by cppcheck
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> lib/route/route_obj.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/route/route_obj.c b/lib/route/route_obj.c
> index 4e14d6d..8f1d4d5 100644
> --- a/lib/route/route_obj.c
> +++ b/lib/route/route_obj.c
> @@ -403,7 +403,7 @@ static int route_compare(struct nl_object *_a, struct
> nl_object *_b, diff |= ROUTE_DIFF(FLAGS,
> (a->rt_flags ^ b->rt_flags) & b->rt_flag_mask);
> } else {
> - if (a->rt_nr_nh != a->rt_nr_nh)
> + if (a->rt_nr_nh != b->rt_nr_nh)
> goto nh_mismatch;
>
> /* search for a dup in each nh of a */
Just a short reminder: This patch is still pending.
Cheers,
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-30 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-24 16:22 [libnl-nft PATCH] Fix the route object comparison using the wrong pointer Thomas Jarosch
2011-09-30 11:26 ` Thomas Jarosch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.