[ulogd2 PATCH] Fix bracket imbalance if IPPROTO_SCTP is defined

[ulogd2 PATCH] Fix bracket imbalance if IPPROTO_SCTP is defined

[Thomas Jarosch]

Detected by cppcheck.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
 output/ulogd_output_IPFIX.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/output/ulogd_output_IPFIX.c b/output/ulogd_output_IPFIX.c
index 025faab..f7856d2 100644
--- a/output/ulogd_output_IPFIX.c
+++ b/output/ulogd_output_IPFIX.c
@@ -406,6 +406,7 @@ static int open_connect_socket(struct ulogd_pluginstance *pi)
 				freeaddrinfo(resave);
 				return ret;
 			}
+		}
 #endif
 
 		if (connect(ii->fd, res->ai_addr, res->ai_addrlen) != 0) {
-- 
1.7.4.4

Re: [ulogd2 PATCH] Fix bracket imbalance if IPPROTO_SCTP is defined

[Jan Engelhardt]

On Wednesday 2011-08-24 18:31, Thomas Jarosch wrote:

>Detected by cppcheck.

This is still applicable.

>diff --git a/output/ulogd_output_IPFIX.c b/output/ulogd_output_IPFIX.c
>index 025faab..f7856d2 100644
>--- a/output/ulogd_output_IPFIX.c
>+++ b/output/ulogd_output_IPFIX.c
>@@ -406,6 +406,7 @@ static int open_connect_socket(struct ulogd_pluginstance *pi)
> 				freeaddrinfo(resave);
> 				return ret;
> 			}
>+		}
> #endif
> 
> 		if (connect(ii->fd, res->ai_addr, res->ai_addrlen) != 0) {
>-- 
>1.7.4.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [ulogd2 PATCH] Fix bracket imbalance if IPPROTO_SCTP is defined

[Pablo Neira Ayuso]

On Fri, Aug 03, 2012 at 08:34:22PM +0200, Jan Engelhardt wrote:
> On Wednesday 2011-08-24 18:31, Thomas Jarosch wrote:
> 
> >Detected by cppcheck.
> 
> This is still applicable.

Applied, thanks.

Still, the ipfix plugin needs one spin. The current snapshot doesn't
work, that's why it's kept out of the compilation.

It shouldn't be hard to fix it. If anyone interested in contributing
to Netfilter projects, this should be a good one to start with.

If not, I'll find the time to get it working.