From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Schwarz <simonschwarzcor@googlemail.com>
Date: Fri, 26 Aug 2011 18:40:33 +0200
Subject: [U-Boot] [PATCH V3 4/8] omap-common/spl: Add linux boot to SPL
In-Reply-To: <4E578201.9030108@gmail.com>
References: <1314182363-25732-1-git-send-email-simonschwarzcor@gmail.com>
	<1314261196-23197-1-git-send-email-simonschwarzcor@gmail.com>
	<1314261196-23197-5-git-send-email-simonschwarzcor@gmail.com>
	<4E5631F2.8030705@gmail.com> <4E5772D5.101@gmail.com>
	<4E57793A.2080504@gmail.com> <4E578201.9030108@gmail.com>
Message-ID: <4E57CC81.10700@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/26/2011 01:22 PM, Simon Schwarz wrote:
> Dear Andreas,
>
> On 08/26/2011 12:45 PM, Andreas Bie?mann wrote:
>> Dear Simon
>>
>> Am 26.08.2011 12:17, schrieb Simon Schwarz:
>>> On 08/25/2011 01:28 PM, Andreas Bie?mann wrote:
>>>> Dear Simon,
>>
>> <snip>
>>
>>>>> +/* This function jumps to an image with argument. Normally an FDT or
>>>>> ATAGS
>>>>> + * image.
>>>>> + * arg: Pointer to paramter image in RAM
>>>>> + */
>>>>> +void jump_to_image_linux(void *arg)
>>>>> +{
>>>>> + debug("Entering kernel arg pointer: 0x%X\n", arg);
>>>>> + typedef void (*image_entry_arg_t)(int, int, void *)
>>>>> + __attribute__ ((noreturn));
>>>>> + image_entry_arg_t image_entry =
>>>>> + (image_entry_arg_t) spl_image.entry_point;
>>>>> + /* cleanup_before_linux(); */ /*write SPL function for that*/
>>>>> + image_entry(0, CONFIG_SYS_SPL_MACHID, arg);
>>>>
>>>> the MACHID is saved in gd->bd, couldn't this be used here?
>>>> BTW: You missed setting CONFIG_SYS_SPL_MACHID in your board
>>>> configuration header in this patch. Where is it done?
>>>>
>>>
>>> In SPL gd is not fully initialized.
>>
>> I see ... but how about using existing CONFIG_MACH_TYPE then?
>>
>
> done.
>
I correct myself: not done.

If I use CONFIG_MACH_TYPE u-boot doesn't boot any more. This seems to be 
a bug in handling this define.

Any ideas on this?

Regards
Simon