From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219Ab1H2Ca1 (ORCPT ); Sun, 28 Aug 2011 22:30:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948Ab1H2CaW (ORCPT ); Sun, 28 Aug 2011 22:30:22 -0400 Message-ID: <4E5AF989.106@redhat.com> Date: Mon, 29 Aug 2011 10:29:29 +0800 From: Cong Wang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110817 Fedora/3.1.12-1.fc14 Thunderbird/3.1.12 MIME-Version: 1.0 To: David Rientjes CC: Randy Dunlap , Andrew Morton , Stephen Rothwell , gregkh@suse.de, linux-next@vger.kernel.org, LKML , linux-mm@kvack.org Subject: Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c References: <20110804145834.3b1d92a9eeb8357deb84bf83@canb.auug.org.au> <20110804152211.ea10e3e7.rdunlap@xenotime.net> <20110823143912.0691d442.akpm@linux-foundation.org> <4E547155.8090709@redhat.com> <20110824191430.8a908e70.rdunlap@xenotime.net> <4E55C221.8080100@redhat.com> <20110824205044.7ff45b6c.rdunlap@xenotime.net> <4E562248.2090102@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2011年08月26日 04:57, David Rientjes 写道: > On Thu, 25 Aug 2011, Cong Wang wrote: > >>> No, it doesn't work, CONFIG_HUGETLBFS can be enabled with CONFIG_NUMA=y >>> and CONFIG_SYSFS=n and that uses data structures from drivers/base/node.c >>> which doesn't get compiled with this patch. >> >> So, you mean with CONFIG_NUMA=y&& CONFIG_SYSFS=n&& CONFIG_HUGETLBFS=y >> we still get compile error? >> >> Which data structures are used by hugetlbfs? >> > > node_states[], which is revealed at link time if you tried to compile your > patch. It's obvious that we don't want to add per-node hugetlbfs > attributes to sysfs directories if sysfs is disabled, so you need to > modify the hugetlbfs code as well. Makes sense. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c Date: Mon, 29 Aug 2011 10:29:29 +0800 Message-ID: <4E5AF989.106@redhat.com> References: <20110804145834.3b1d92a9eeb8357deb84bf83@canb.auug.org.au> <20110804152211.ea10e3e7.rdunlap@xenotime.net> <20110823143912.0691d442.akpm@linux-foundation.org> <4E547155.8090709@redhat.com> <20110824191430.8a908e70.rdunlap@xenotime.net> <4E55C221.8080100@redhat.com> <20110824205044.7ff45b6c.rdunlap@xenotime.net> <4E562248.2090102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Randy Dunlap , Andrew Morton , Stephen Rothwell , gregkh@suse.de, linux-next@vger.kernel.org, LKML , linux-mm@kvack.org List-Id: linux-next.vger.kernel.org =E4=BA=8E 2011=E5=B9=B408=E6=9C=8826=E6=97=A5 04:57, David Rientjes =E5=86= =99=E9=81=93: > On Thu, 25 Aug 2011, Cong Wang wrote: > >>> No, it doesn't work, CONFIG_HUGETLBFS can be enabled with CONFIG_NUMA= =3Dy >>> and CONFIG_SYSFS=3Dn and that uses data structures from drivers/base/= node.c >>> which doesn't get compiled with this patch. >> >> So, you mean with CONFIG_NUMA=3Dy&& CONFIG_SYSFS=3Dn&& CONFIG_HUGETL= BFS=3Dy >> we still get compile error? >> >> Which data structures are used by hugetlbfs? >> > > node_states[], which is revealed at link time if you tried to compile y= our > patch. It's obvious that we don't want to add per-node hugetlbfs > attributes to sysfs directories if sysfs is disabled, so you need to > modify the hugetlbfs code as well. Makes sense. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter= .ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 10724900138 for ; Sun, 28 Aug 2011 22:29:46 -0400 (EDT) Message-ID: <4E5AF989.106@redhat.com> Date: Mon, 29 Aug 2011 10:29:29 +0800 From: Cong Wang MIME-Version: 1.0 Subject: Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c References: <20110804145834.3b1d92a9eeb8357deb84bf83@canb.auug.org.au> <20110804152211.ea10e3e7.rdunlap@xenotime.net> <20110823143912.0691d442.akpm@linux-foundation.org> <4E547155.8090709@redhat.com> <20110824191430.8a908e70.rdunlap@xenotime.net> <4E55C221.8080100@redhat.com> <20110824205044.7ff45b6c.rdunlap@xenotime.net> <4E562248.2090102@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Randy Dunlap , Andrew Morton , Stephen Rothwell , gregkh@suse.de, linux-next@vger.kernel.org, LKML , linux-mm@kvack.org ao? 2011a1'08ae??26ae?JPY 04:57, David Rientjes a??e??: > On Thu, 25 Aug 2011, Cong Wang wrote: > >>> No, it doesn't work, CONFIG_HUGETLBFS can be enabled with CONFIG_NUMA=y >>> and CONFIG_SYSFS=n and that uses data structures from drivers/base/node.c >>> which doesn't get compiled with this patch. >> >> So, you mean with CONFIG_NUMA=y&& CONFIG_SYSFS=n&& CONFIG_HUGETLBFS=y >> we still get compile error? >> >> Which data structures are used by hugetlbfs? >> > > node_states[], which is revealed at link time if you tried to compile your > patch. It's obvious that we don't want to add per-node hugetlbfs > attributes to sysfs directories if sysfs is disabled, so you need to > modify the hugetlbfs code as well. Makes sense. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org