From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy92L-0006tB-4E for qemu-devel@nongnu.org; Mon, 29 Aug 2011 17:06:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy92J-0008LB-Oh for qemu-devel@nongnu.org; Mon, 29 Aug 2011 17:06:29 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:42841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy92J-0008L7-Di for qemu-devel@nongnu.org; Mon, 29 Aug 2011 17:06:27 -0400 Message-ID: <4E5BFF51.9010503@web.de> Date: Mon, 29 Aug 2011 23:06:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E58FC3F.6080809@web.de> <4E5BE7C5.60705@us.ibm.com> In-Reply-To: <4E5BE7C5.60705@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC59623C6B66E127DAC352A0E" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lucas Meneghel Rodrigues , Avi Kivity , Marcelo Tosatti , Gerd Hoffmann , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC59623C6B66E127DAC352A0E Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-08-29 21:25, Anthony Liguori wrote: > On 08/27/2011 09:16 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> The master PIC is connected to the LINTIN0 of the APICs. As the APIC >> currently does not track the state of that line, we have to ask the PI= C >> to re-inject its IRQ after the CPU picked up an event from the APIC. >> >> Adds the proper state tracking so that we can already re-assert the CP= U >> IRQ at APIC level if there is a pending PIC IRQ. This allows to remove= >> all the old workarounds. >> >> The patch also fixes some failures of the kvm unit tests apic and >> eventinj by enabling a proper CPU IRQ deassert when the guest masks so= me >> pending IRQs at PIC level. >> >> Signed-off-by: Jan Kiszka >> --- >> >> It turned out that this patch from a larger cleanup series has no >> dependencies and can be applied directly to master to fix the observed= >> bug. >> >> hw/apic.c | 4 +++- >> hw/i8259.c | 10 ++-------- >> hw/pc.c | 3 --- >> hw/pc.h | 1 - >> 4 files changed, 5 insertions(+), 13 deletions(-) >> >> diff --git a/hw/apic.c b/hw/apic.c >> index d8f56c8..22ad635 100644 >> --- a/hw/apic.c >> +++ b/hw/apic.c >> @@ -104,6 +104,7 @@ struct APICState { >> QEMUTimer *timer; >> int sipi_vector; >> int wait_for_sipi; >> + int pic_level; >> }; >=20 > Does this need to be save/restored for migration? Nope, but we need some other measure. I thought to remember the pic was refreshing this after load, but I do not find any traces of this now. We likely need a post_load handler in the i8259 that re-asserts the IRQ as required. Jan --------------enigC59623C6B66E127DAC352A0E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5b/1IACgkQitSsb3rl5xTP6gCg5fGNafmnNT8rVKOkrsmjHMcy qOIAniT8+zpKqJAOWQ+TPrb8uyfhQZov =Y7Zd -----END PGP SIGNATURE----- --------------enigC59623C6B66E127DAC352A0E--