From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyJZq-0005Qv-GY for qemu-devel@nongnu.org; Tue, 30 Aug 2011 04:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyJZo-0001nX-Jv for qemu-devel@nongnu.org; Tue, 30 Aug 2011 04:21:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyJZo-0001nE-Cs for qemu-devel@nongnu.org; Tue, 30 Aug 2011 04:21:44 -0400 Message-ID: <4E5C9D93.7000806@redhat.com> Date: Tue, 30 Aug 2011 11:21:39 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E5BB170.90305@redhat.com> <4E5BBB8A.50104@siemens.com> <4E5BBCCB.2020508@siemens.com> <4E5BE527.2010601@codemonkey.ws> <4E5C0161.6020209@redhat.com> <4E5C14E0.9060800@web.de> In-Reply-To: <4E5C14E0.9060800@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Fix memory_region_get_ram_ptr for ROM devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" On 08/30/2011 01:38 AM, Jan Kiszka wrote: > On 2011-08-29 23:15, Avi Kivity wrote: > > On 08/29/2011 10:14 PM, Anthony Liguori wrote: > >>> OK, that was simple: It's still "pflash_cfi01/pflash_cfi02: convert to > >>> memory API". > >> > >> > >> Hrm, okay. Avi, maybe drop that patch and submit a v3? > >> > > > > Of course. I'm sta^Wcontinuing to hate that pflash thing. > > It's not always the pflash... :) I'm willing to hate rom_device equally. There's enough to go round. > ---8<--- > > From: Jan Kiszka > > Mask out the sub-page bits that are used by ROM device for storing the > io-index and the IO_MEM_ROMD flag. Applied; thanks for the help. With this, everything works, yes? -- error compiling committee.c: too many arguments to function