From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QynIt-0007AF-1S
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:06:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QynIs-0007t4-2C
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:06:15 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:46769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QynIr-0007sx-UP
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 12:06:14 -0400
Received: by gwb19 with SMTP id 19so214037gwb.4
	for <qemu-devel@nongnu.org>; Wed, 31 Aug 2011 09:06:12 -0700 (PDT)
Message-ID: <4E5E5BF3.50801@codemonkey.ws>
Date: Wed, 31 Aug 2011 11:06:11 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1314752751.84463.YahooMailClassic@web27003.mail.ukl.yahoo.com>	<4E5D8BAA.9010302@codemonkey.ws>	<alpine.LNX.2.00.1108310527290.3538@linmac>	<4E5D9570.1030201@codemonkey.ws>	<alpine.LNX.2.00.1108311716530.1522@linmac>	<4E5E3789.3010603@codemonkey.ws>	<alpine.LNX.2.00.1108311736160.1880@linmac>	<4E5E39DF.3080609@codemonkey.ws>	<alpine.LNX.2.00.1108311750480.1958@linmac>	<4E5E4540.5030408@codemonkey.ws>
	<alpine.LNX.2.00.1108311830270.2400@linmac>
In-Reply-To: <alpine.LNX.2.00.1108311830270.2400@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, bifferos <bifferos@yahoo.co.uk>

On 08/31/2011 09:35 AM, malc wrote:
> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>
>> Upper case field names are not okay.  If you think coding style isn't clear,
>> that's a bug in coding style.
>
> Sez hu? Coding style is garbage that should be thrown out of the window.
> As for looking, yeah, i'm looking at usb with it's lovely hungarian
> fields, should we stampede to "fix" it?
>
> If the one who's going to maintain the code is fine with whatever naming
> is used so be it.

No.  That's how we got into the coding style mess we're in in the first 
place.

There's no benefit to going through and changing existing code but new 
code needs to be consistent with the vast majority of code in the rest 
of the tree.  It's about overall code base consistency and maintainability.

Regards,

Anthony Liguori

>
> [..snip..]
>