From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz14C-0005KK-SR for qemu-devel@nongnu.org; Thu, 01 Sep 2011 02:48:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qz14A-0005uc-6P for qemu-devel@nongnu.org; Thu, 01 Sep 2011 02:48:00 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:44516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz14A-0005u1-3L for qemu-devel@nongnu.org; Thu, 01 Sep 2011 02:47:58 -0400 Received: by iabz25 with SMTP id z25so1792774iab.4 for ; Wed, 31 Aug 2011 23:47:57 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E5F2A95.6000403@redhat.com> Date: Thu, 01 Sep 2011 08:47:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1314857389-13363-1-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1314857389-13363-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, aliguori@us.ibm.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, agraf@suse.de On 09/01/2011 08:09 AM, David Gibson wrote: > The patch defines wmb() as __sync_synchronize(), a cross platform memory > barrier primitive available in sufficiently recent gcc versions (gcc 4.2 > and after?). If we care about older gccs then this patch will need to > be updated with some sort of fallback. Yes, though RHEL5's 4.1 has it backported. > Signed-off-by: Alexey Kardashevskiy > Signed-off-by: David Gibson It will most definitely break OpenBSD, but anyway: Acked-by: Paolo Bonzini Paolo