From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz2yq-0004Vb-BG for qemu-devel@nongnu.org; Thu, 01 Sep 2011 04:50:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qz2yp-0004FW-6V for qemu-devel@nongnu.org; Thu, 01 Sep 2011 04:50:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qz2yo-0004FN-UU for qemu-devel@nongnu.org; Thu, 01 Sep 2011 04:50:35 -0400 Message-ID: <4E5F4744.1090809@redhat.com> Date: Thu, 01 Sep 2011 11:50:12 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314806132-32389-1-git-send-email-peter.maydell@linaro.org> <1314806132-32389-3-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1314806132-32389-3-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] omap_intc: Qdevify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , =?ISO-8859-1?Q?Juha_Riihim=E4ki?= , qemu-devel@nongnu.org, patches@linaro.org On 08/31/2011 06:55 PM, Peter Maydell wrote: > Convert the omap_intc devices to qdev. This includes adding > a 'revision' property which will be needed for omap3. > > The bulk of this patch is the replacement of "s->irq[x][y]" > with "qdev_get_gpio_in(s->ih[x], y)" now that the interrupt > controller exposes its input lines as qdev gpio inputs. > > The devices are named "omap-intc" and "omap2-intc", following > the filename and the OMAP2/3 hardware names, although some > internal functions are still named "omap_inth_*". > > Signed-off-by: Peter Maydell > --- > hw/nseries.c | 4 +- > hw/omap.h | 19 +-------- > hw/omap1.c | 127 +++++++++++++++++++++++++++++++++++-------------------- > hw/omap2.c | 92 ++++++++++++++++++++++++----------------- > hw/omap_intc.c | 125 +++++++++++++++++++++++++++++++++--------------------- > 5 files changed, 215 insertions(+), 152 deletions(-) > This is likely to conflict with my omap1 patches in memory/queue. -- error compiling committee.c: too many arguments to function