From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzC2a-0006WU-46 for qemu-devel@nongnu.org; Thu, 01 Sep 2011 14:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzC2Z-0003C2-3p for qemu-devel@nongnu.org; Thu, 01 Sep 2011 14:31:04 -0400 Received: from goliath.siemens.de ([192.35.17.28]:20874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzC2Y-0003BO-R5 for qemu-devel@nongnu.org; Thu, 01 Sep 2011 14:31:03 -0400 Message-ID: <4E5FCF61.4040404@siemens.com> Date: Thu, 01 Sep 2011 20:30:57 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1314900738-30164-1-git-send-email-lcapitulino@redhat.com> <1314900738-30164-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1314900738-30164-4-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] RunState: Add additional states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: "kwolf@redhat.com" , "amit.shah@redhat.com" , "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "armbru@redhat.com" On 2011-09-01 20:12, Luiz Capitulino wrote: > Currently, only vm_start() and vm_stop() change the VM state. > That's, the state is only changed when starting or stopping the VM. > > This commit adds the runstate_set() function, which makes it possible > to also do state transitions when the VM is stopped or running. > > Additional states are also added and the current state is stored. > > Signed-off-by: Luiz Capitulino > --- > cpus.c | 1 + > migration.c | 8 +++++++- > sysemu.h | 10 +++++++++- > vl.c | 20 ++++++++++++++++++++ > 4 files changed, 37 insertions(+), 2 deletions(-) > ... > diff --git a/vl.c b/vl.c > index f0b56a4..59f71fc 100644 > --- a/vl.c > +++ b/vl.c > @@ -321,6 +321,22 @@ static int default_driver_check(QemuOpts *opts, void *opaque) > } > > /***********************************************************/ > +/* QEMU state */ > + > +static RunState current_run_state = RSTATE_NO_STATE; > + > +bool runstate_check(RunState state) > +{ > + return current_run_state == state; > +} > + > +void runstate_set(RunState state) > +{ > + assert(state < RSTATE_MAX); > + current_run_state = state; I still think this should check for valid state transitions instead of blindly accepting what the caller passes in. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux