From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58851)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QzD4W-00075O-Ia
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 15:37:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QzD4V-0007w2-5A
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 15:37:08 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:35867)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QzD4V-0007vh-2m
	for qemu-devel@nongnu.org; Thu, 01 Sep 2011 15:37:07 -0400
Received: by gwb19 with SMTP id 19so1295259gwb.4
	for <qemu-devel@nongnu.org>; Thu, 01 Sep 2011 12:37:06 -0700 (PDT)
Message-ID: <4E5FDEE0.2010908@codemonkey.ws>
Date: Thu, 01 Sep 2011 14:37:04 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1314891739-1881-1-git-send-email-kraxel@redhat.com>
	<1314891739-1881-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1314891739-1881-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] Probe for libcheck by default.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/01/2011 10:42 AM, Gerd Hoffmann wrote:
> Probe for libcheck and build checks (if found) by default.
> Can be explicitly disabled using --disable-check-utests.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   configure |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

I think we should convert the check tests to gtest, and then have make 
check use gtester and gtester-report generate a single report of all of 
the test cases.

We could then have build bot run make check and post the output.  I 
don't want to end up with a bunch of non gtest unit tests...

Regards,

Anthony Liguori

>
> diff --git a/configure b/configure
> index 1340c33..920de9e 100755
> --- a/configure
> +++ b/configure
> @@ -170,7 +170,7 @@ mixemu="no"
>   aix="no"
>   blobs="yes"
>   pkgversion=""
> -check_utests="no"
> +check_utests=""
>   user_pie="no"
>   zero_malloc=""
>   trace_backend="nop"