From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTlS-0006Sn-QG for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzTlR-000265-Dw for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:26:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37490 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTlR-000260-2M for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:26:33 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 5C03B8B2F9 for ; Fri, 2 Sep 2011 15:26:32 +0200 (CEST) Message-ID: <4E60D983.60808@suse.de> Date: Fri, 02 Sep 2011 15:26:27 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1313030188-19347-1-git-send-email-david@gibson.dropbear.id.au> <1313030188-19347-3-git-send-email-david@gibson.dropbear.id.au> <1C49B879-F90D-4D8D-8783-EC4A34875EE7@suse.de> <20110901015050.GI11906@yookeroo.fritz.box> In-Reply-To: <20110901015050.GI11906@yookeroo.fritz.box> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] pseries: Implement hcall-bulk hypervisor interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 09/01/2011 03:50 AM, David Gibson wrote: > On Wed, Aug 31, 2011 at 11:22:18AM +0200, Alexander Graf wrote: >> On 11.08.2011, at 04:36, David Gibson wrote: > [snip] >>> +#define H_BULK_REMOVE_TYPE 0xc000000000000000ULL >>> +#define H_BULK_REMOVE_REQUEST 0x4000000000000000ULL >>> +#define H_BULK_REMOVE_RESPONSE 0x8000000000000000ULL >>> +#define H_BULK_REMOVE_END 0xc000000000000000ULL >>> +#define H_BULK_REMOVE_CODE 0x3000000000000000ULL >>> +#define H_BULK_REMOVE_SUCCESS 0x0000000000000000ULL >>> +#define H_BULK_REMOVE_NOT_FOUND 0x1000000000000000ULL >>> +#define H_BULK_REMOVE_PARM 0x2000000000000000ULL >>> +#define H_BULK_REMOVE_HW 0x3000000000000000ULL >>> +#define H_BULK_REMOVE_RC 0x0c00000000000000ULL >>> +#define H_BULK_REMOVE_FLAGS 0x0300000000000000ULL >>> +#define H_BULK_REMOVE_ABSOLUTE 0x0000000000000000ULL >>> +#define H_BULK_REMOVE_ANDCOND 0x0100000000000000ULL >>> +#define H_BULK_REMOVE_AVPN 0x0200000000000000ULL >>> +#define H_BULK_REMOVE_PTEX 0x00ffffffffffffffULL >> indenting looks broken. > Nope, that's intended. The unindented ones are the field masks in the > parameter, the intended ones are the defined values for the > corresponding field. Interesting :). Makes sense now that you explain it - looked awkward at first. >>> + >>> +static target_ulong h_bulk_remove(CPUState *env, sPAPREnvironment *spapr, >>> + target_ulong opcode, target_ulong *args) >>> +{ >>> + int i; >>> + >>> + for (i = 0; i< 4; i++) { >>> + target_ulong *tsh =&args[i*2]; >>> + target_ulong tsl = args[i*2 + 1]; >> Mind to replace all those magic numbers by something more verbose? > So, "all those" == 2. I can replace the 4 with something I guess, but > changing the 2 would just be silly - that code is just taking the > arguments a pair at a time. Yup. Thanks! Applied. Alex