From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0qN0-0003gZ-QS
	for qemu-devel@nongnu.org; Tue, 06 Sep 2011 03:46:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0qMz-0006os-Lb
	for qemu-devel@nongnu.org; Tue, 06 Sep 2011 03:46:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29167)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0qMz-0006ok-CQ
	for qemu-devel@nongnu.org; Tue, 06 Sep 2011 03:46:57 -0400
Message-ID: <4E65CFEA.70604@redhat.com>
Date: Tue, 06 Sep 2011 10:46:50 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4E58FC3F.6080809@web.de> <4E5BE7C5.60705@us.ibm.com>
	<4E5BFF51.9010503@web.de> <4E5C00F0.9070103@redhat.com>
	<CAAu8pHs+thsnWrmvWg45BDVLkiVj682GNpbEMUnCCZ6qnyK+YA@mail.gmail.com>
	<4E5DF096.6070207@redhat.com>
	<CAAu8pHucV2HGqt4tnh+GZ=V-wd0+=u=emODB-MZoqrRCtT5LKA@mail.gmail.com>
	<4E6285BB.2010505@codemonkey.ws>
	<20110905083857.GB26890@edde.se.axis.com>
	<CAAu8pHsACZ_jf=2yg7ZCTjz2fdA4q9y9bbbaQQNtRgq35gPw2A@mail.gmail.com>
In-Reply-To: <CAAu8pHsACZ_jf=2yg7ZCTjz2fdA4q9y9bbbaQQNtRgq35gPw2A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Jan Kiszka <jan.kiszka@web.de>, Gerd Hoffmann <kraxel@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

On 09/05/2011 10:36 PM, Blue Swirl wrote:
> >  I don't agree. That's not what qemu_irq represents.
> >  It represents a wire, a mechanism to drive changes through logic paths
> >  between state. It is intrinsically stateless.
> >
> >  It may be the case that it is missused in some places, or that it isn't
> >  always the best thing to use to represent what ever you need to represent,
> >  so that you want to complement with other mechanisms.
> >  But universally replacing it with a stateful alternative seems wrong to me.
>
> Maybe there could be a stateless version of Pin for optimization:
> Line? This would probably save one bool worth of memory and one memory
> store access for each IRQ event.

Let's actually measure the effect of the bool/store before we optimize 
it away.

-- 
error compiling committee.c: too many arguments to function